Skip to content

Commit b5766b7

Browse files
authored
Prevent JVM Segfault (#294)
* testing import order of java * import dask_cuda before any dask_sql import * try import for dask_cuda * try import and noqa for unused import * fix simple syntax mistake * formatting issues * testing for segfaults * more testing * replace fix * noqa F401 * address review comments * change ordering
1 parent 6237b9c commit b5766b7

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

dask_sql/context.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,11 @@
99
from dask.base import optimize
1010
from dask.distributed import Client
1111

12+
try:
13+
import dask_cuda # noqa: F401
14+
except ImportError: # pragma: no cover
15+
pass
16+
1217
from dask_sql import input_utils
1318
from dask_sql.datacontainer import (
1419
UDF,

tests/integration/fixtures.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@
1111

1212
try:
1313
import cudf
14+
15+
# importing to check for JVM segfault
16+
import dask_cudf # noqa: F401
17+
from dask_cuda import LocalCUDACluster # noqa: F401
1418
except ImportError:
1519
cudf = None
1620

0 commit comments

Comments
 (0)