Skip to content

Commit e9abdfb

Browse files
authoredMay 13, 2024··
Fix incorrectly documentet kwargs in AWS ECS (#426)
when kwargs is typed as `kwargs: dict`, this is interpreted as Dict[str, dict]. See https://peps.python.org/pep-0484/#arbitrary-argument-lists-and-default-argument-values
1 parent 35e4d1d commit e9abdfb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed
 

‎dask_cloudprovider/aws/ecs.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,7 @@ class Scheduler(Task):
371371
Any extra command line arguments to pass to dask-scheduler, e.g. ``["--tls-cert", "/path/to/cert.pem"]``
372372
373373
Defaults to `None`, no extra command line arguments.
374-
kwargs: Dict()
374+
kwargs:
375375
Other kwargs to be passed to :class:`Task`.
376376
377377
See :class:`Task` for parameter info.
@@ -413,7 +413,7 @@ class Worker(Task):
413413
scheduler: str
414414
The address of the scheduler
415415
416-
kwargs: Dict()
416+
kwargs:
417417
Other kwargs to be passed to :class:`Task`.
418418
"""
419419

@@ -682,7 +682,7 @@ class ECSCluster(SpecCluster, ConfigMixin):
682682
mounted in worker tasks. This setting controls whether volumes are also mounted in the scheduler task.
683683
684684
Default ``False``.
685-
**kwargs: dict
685+
**kwargs:
686686
Additional keyword arguments to pass to ``SpecCluster``.
687687
688688
Examples
@@ -1396,7 +1396,7 @@ class FargateCluster(ECSCluster):
13961396
13971397
Parameters
13981398
----------
1399-
kwargs: dict
1399+
kwargs:
14001400
Keyword arguments to be passed to :class:`ECSCluster`.
14011401
14021402
Examples

0 commit comments

Comments
 (0)
Please sign in to comment.