-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify when and how signatures are generated for hypercore DEP #39
Comments
If you are doing an implementation (as noted on IRC), you might be interested in these notes: https://github.com/bnewbold/geniza/blob/master/notes/crypto/notes.txt I think @yoshuawuyts also started a "how to implement dat" guide as part of datrs... maybe this? https://github.com/datrs/book/tree/master/src |
And datrs/tree-index#7 cool stuff there as well :) |
@RangerMauve I went to make the PR but I'm not 100% what aspect was unclear. (Sorry to put this on you but) could you make an PR or suggest some language that you think would clarify this? |
Sure, I'll do a PR. Basically, I just want to add some psuedocode to show how signatures are generated for a node, and how they are verified once you get a node. |
@RangerMauve Okay awesome 👍 gracias! |
The hypercore DEP (0002) contains some useful example code for how nodes are hashed.
I think it's important to do the same thing for signing these nodes because it was a little hard to follow the internals in hypercore and hypercore-crypto to find this line.
The text was updated successfully, but these errors were encountered: