Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Incorrect entry size for bitfield in DEP-0009 #68

Open
smoyer64 opened this issue Jan 25, 2021 · 2 comments
Open

Bug: Incorrect entry size for bitfield in DEP-0009 #68

smoyer64 opened this issue Jan 25, 2021 · 2 comments

Comments

@smoyer64
Copy link

DEP-0009 states that the entry size for the bitfield file should be 3328 (0x0d00) but the hypercore files I've found all use 3584 (0x0e00) for the entry size in these files.

@bnewbold
Copy link
Contributor

This may be because newer hypercore (the implementation) has diverged from this DEP?

I checked some 2017-era .dat/*.bitfield files and they are 3360 bytes, which is consistent with a 32 byte SLEEP header plus 3328 bitfield entry size.

@smoyer64
Copy link
Author

I found a reference elsewhere that points to holepunchto/hypercore#184 so I suspect that you might be right. So should hyper be considered to be a superceding implementation of dat?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants