Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a temporary implementation for array_api.compat.torch.unique_all instead of raising NotImplementedError #135

Open
ogrisel opened this issue May 7, 2024 · 1 comment

Comments

@ogrisel
Copy link

ogrisel commented May 7, 2024

The first snippet provided in this comment pytorch/pytorch#36748 (comment) might help smooth support for torch in Array API consuming libraries such as scikit-learn without them having to maintain their own hacks while waiting upstream PyTorch to address pytorch/pytorch#70920.

@asmeurer
Copy link
Member

asmeurer commented May 7, 2024

This sounds reasonable. Based on the code comments, the workarounds there didn't work because they used non-deterministic scatter. But if those workarounds you referenced don't have that issue, we can implement them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants