Skip to content

Commit ebd9350

Browse files
committed
use file_path in dashboard definition for a bind dashboard acceptance test
1 parent c6522c6 commit ebd9350

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

NEXT_CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
### CLI
66

77
### Bundles
8-
* Add support for dashboards in deployment bind/unbind commands
8+
* Add support for dashboards in deployment bind/unbind commands ([#2516](https://github.com/databricks/cli/pull/2516))
99

1010
* Processing 'artifacts' section is now done in "bundle validate" (adding defaults, inferring "build", asserting required fields) ([#2526])(https://github.com/databricks/cli/pull/2526))
1111
* When uploading artifacts, include relative path in log message ([#2539])(https://github.com/databricks/cli/pull/2539))

acceptance/bundle/deployment/bind/dashboard/databricks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ resources:
77
display_name: $DASHBOARD_DISPLAY_NAME
88
warehouse_id: $TEST_DEFAULT_WAREHOUSE_ID
99
embed_credentials: true
10-
serialized_dashboard: '{"pages":[{"name":"02724bf2","displayName":"Page 1"}]}'
10+
file_path: "sample-dashboard.lvdash.json"
1111
parent_path: /Users/$CURRENT_USER_NAME
1212

acceptance/bundle/deployment/bind/dashboard/output.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Deployment complete!
1515
"lifecycle_state": "ACTIVE",
1616
"path": "/Users/[USERNAME]/test dashboard [UUID].lvdash.json",
1717
"parent_path": "/Users/[USERNAME]",
18-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page 1\"}]}"
18+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\"}]}"
1919
}
2020

2121
=== Unbind the dashboard: Updating deployment state...
@@ -30,7 +30,7 @@ Destroy complete!
3030
"lifecycle_state": "ACTIVE",
3131
"path": "/Users/[USERNAME]/test dashboard [UUID].lvdash.json",
3232
"parent_path": "/Users/[USERNAME]",
33-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page 1\"}]}"
33+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\"}]}"
3434
}
3535

3636
=== Test cleanup:
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
{"pages":[{"name":"02724bf2","displayName":"Page One"}]}

acceptance/bundle/deployment/bind/dashboard/test.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Response.Body = '''
2626
"lifecycle_state": "ACTIVE",
2727
"path": "/Users/[USERNAME]/test dashboard [UUID].lvdash.json",
2828
"parent_path": "/Users/[USERNAME]",
29-
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page 1\"}]}"
29+
"serialized_dashboard": "{\"pages\":[{\"name\":\"02724bf2\",\"displayName\":\"Page One\"}]}"
3030
}
3131
'''
3232

0 commit comments

Comments
 (0)