Skip to content

Change comments from required_boroughs to expected_boroughs #219

Open
@pinnamaneni2005

Description

@pinnamaneni2005

Change comments from required_boroughs to expected_boroughs in Iceberg - Integrated Audits Demo.ipynb file:

Since boroughs and expected_boroughs are both sets (array of distinct items),

we can confirm that they match by checking that the lengths of the sets are equal

to eachother as well as to the union of both sets.

if len(boroughs) != len(expected_boroughs) != len(set.union(boroughs, expected_boroughs)):
raise ValueError(f"Audit failed, borough set does not match expected boroughs: {boroughs} != {expected_boroughs}")

after change:

Since boroughs and required_boroughs are both sets (array of distinct items),

we can confirm that they match by checking that the lengths of the sets are equal

to eachother as well as to the union of both sets.

if len(boroughs) != len(expected_boroughs) != len(set.union(boroughs, expected_boroughs)):
raise ValueError(f"Audit failed, borough set does not match expected boroughs: {boroughs} != {expected_boroughs}")

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions