Skip to content

[BUG]: Morpheus conversion success comment is getting added to BB conversion #1743

Open
@biswadeepupadhyay-db

Description

@biswadeepupadhyay-db

Is there an existing issue for this?

  • I have searched the existing issues

Category of Bug / Issue

Converter bug

Current Behavior

I noticed that while trying an Oracle SQL code conversion from Lakebridge, the following comment was added at the top of the converted code.

/*
Successfully transpiled from <source-code>
*/

Implication: Lakebridge is adding this comment to all the BB conversions along with Morpheus, as Oracle today is only supported through BB.

The reason this might be a problem:

  1. Today, BB doesn't send any non-zero exit code (except compilation errors) for its SQL/ETL conversion, meaning the targeted output might still not be converted, but placing the comment above in that output file would lead to confusion.
  2. The comment makes sense for Morpheus, as Morpheus throws a runtime error if it encounters a problem during the transpilation and adds appropriate error comments in the output code file otherwise.

Expected Behavior

BB converters should not add that comment to the converted code files.

Steps To Reproduce

Run any Code conversion for a BB-supported source dialect using LakeBridge. E.g., Syapse, Oracle.

Relevant log output or Exception details

Sample Query

Operating System

macOS

Version

latest via Databricks CLI

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions