Schema 4.6 #889
Schema 4.6 #889
Conversation
kaysiz
temporarily deployed
to
vercel-bracco-preview
GitHub Actions
Inactive
|
Deploy preview for bracco ready! ✅ Preview Built with commit 9bd8689. |
There was a problem hiding this comment.
@kaysiz - A couple of comments in the code. Also I left some comments at the vercel preview at https://bracco-rdckjb3ze-datacite.vercel.app/dois/10.82531%2Fta9w-p411. Let me know if you don't see those comments.
app/components/doi-contributor.js
Outdated
There was a problem hiding this comment.
Just a comment. I never realized that we tracked flavors of contributor types. Are these defined somewhere?
For example, where is it defined that translator is not an organizationalContributor. (Just curious)
There was a problem hiding this comment.
@svogt0511 https://datacite-metadata-schema.readthedocs.io/en/4.6_draft/appendices/appendix-1/contributorType/#translator the description gives an idea of what the contributorType group is
There was a problem hiding this comment.
In this case however Transalator can be both personal or organization. From the pattern it should probably just stay in the contributorTypes list. @codycooperross @KellyStathis can weigh in on this.
There was a problem hiding this comment.
It makes sense to me that a Translator could be either Organizational or Personal.
cypress/fixtures/doi.xml
Outdated
There was a problem hiding this comment.
Just a question. Is there a reason why we use both schemaLocation for kernel-4 and kernel-4.6? I thought that using kernel-4 would be the latest.
There was a problem hiding this comment.
@svogt0511 the first part is the namespace and the second is the url to the file that will validate the data
| @@ -43,13 +43,16 @@ const relationTypeList = [ | |||
| 'Is original form of', | |||
| 'Is identical to', | |||
| 'Is collected by', | |||
| 'Collects' | |||
| 'Collects', | |||
There was a problem hiding this comment.
@codycooperross @KellyStathis What order should we follow for this list?
There was a problem hiding this comment.
In the past, I think this list has been additive, i.e. we just keep adding new values at the bottom :) What are some other options? Alphabetical, according to the list in the schema docs: https://datacite-metadata-schema.readthedocs.io/en/4.5/appendices/appendix-1/relationType/ —any others?
| this.fragment.set('relatedIdentifier', value); | ||
| this.fragment.set('relatedIdentifierType', 'RRID'); | ||
| this.set('controlledIdentifierType', true); | ||
| break; |
There was a problem hiding this comment.
This looks good for RRID, and there shouldn't be any collisions with other IDs :) Just curious—did you determine that CSTR might have collisions?
codycooperross
temporarily deployed
to
vercel-bracco-preview
GitHub Actions
Inactive
|
@kaysiz I'm having some trouble entering the 
I might be missing something, but can you take a look? The CSTR example I used was |
Purpose
Add new values for various attributes
These values may be used in 10.a resourceTypeGeneral and other places where resourceTypeGeneral is used (12.f resourceTypeGeneral, 20.a relatedItemType).
These values may be used in 12.a relatedIdentifierType and other places where relatedIdentifierType is used (20.1.a relatedItemIdentifierType).
This value may be used in 7.a contributorType and other places where contributorType is used (20.12.a contributorType).
Spec documents:
closes: #887 #888 #886 #884 #883
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: