Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove NodeTrait #5

Open
yoshuawuyts opened this issue Jun 18, 2018 · 0 comments
Open

Remove NodeTrait #5

yoshuawuyts opened this issue Jun 18, 2018 · 0 comments

Comments

@yoshuawuyts
Copy link
Contributor

Having to expose the NodeTrait just to be able to use the methods on the Node type feels leaky. We should create a "sealed" and "unsealed" Node type, where one acts as a front for the other.

We can do this by creating a facade using https://github.com/chancancode/rust-delegate, which should allow us to seal the trait requirements internally without leaking it.

We should probably name one SealedNode and the other Node. Using Node` exclusively throughout our code as to prevent the sealed version from leaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant