Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seal KeyPair type #7

Open
yoshuawuyts opened this issue Jun 18, 2018 · 3 comments
Open

Seal KeyPair type #7

yoshuawuyts opened this issue Jun 18, 2018 · 3 comments

Comments

@yoshuawuyts
Copy link
Contributor

yoshuawuyts commented Jun 18, 2018 •
edited
Loading

We're forwarding the KeyPair type from another crate. We should create a wrapper type for this.

We should also be able to have a half-opened state for these - e.g. read-write vs just read
@soyuka
Copy link
Contributor

soyuka commented Aug 27, 2018

We should also be able to have a half-opened state for these - e.g. read-write vs just read

Could the PartialKeyPair I added in #18 be the answer?

@yoshuawuyts
Copy link
Contributor Author

@soyuka yeah, definitely! Ideally we could remove any dalek structs from our public interface, and replace it the partial keypair. Would you like to give that a shot?

@soyuka
Copy link
Contributor

soyuka commented Aug 27, 2018

We're not forwarding Keypair anymore if I'm not mistaken. The only thing I see here are Feed and FeedBuilder having PublicKey and Option<SecretKey>. Those two should stay like this.

You can close this imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soyuka @yoshuawuyts