Skip to content

Dead code in Dockerfile #13

@ethanvuillemin

Description

@ethanvuillemin

I just finished your YouTube video on the MCP crash course and noticed something in the Dockerfile section. This is a minor improvement, but I would like to suggest a couple of changes to the Dockerfile to improve its efficiency and coherence.

  1. Removal of Dead Code: The line COPY client appears to be dead code and can be removed as it serves no purpose in the current context.
COPY client.py .
  1. Use of --system for Consistency: To maintain consistency and simplify the Dockerfile, I propose replacing the creation of the uv venv with --system at the end of the line 13. This will make the Dockerfile more straightforward and easier to understand instead of creating an unused virtual env (due to the docker error)
# Install dependencies using uv
RUN uv pip install --system -r requirements.txt

Thank you for your content and for considering these suggestions

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions