Skip to content

Commit 7a18fc0

Browse files
author
David Meza
committed
fix linting errors
1 parent 7e67bd3 commit 7a18fc0

File tree

7 files changed

+12
-12
lines changed

7 files changed

+12
-12
lines changed

.jshintrc

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"unused": true,
1313
"globals": {
1414
"angular": false,
15-
"ga": false
15+
"ga": false,
16+
"google": false
1617
}
1718
}

app/scripts/controllers/parkCtrl.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
Esri.modulesReady().then(function(modules) {
99
$scope.myLocation = function() {
1010
return modules.userMarker.geometry;
11-
}
11+
};
1212
});
1313

1414
// Assign to scope so we can inherit from child directions map scope.

app/scripts/directives/collapseFooter.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
angular.element(document.getElementById('back-to-top')).toggleClass('lower');
2121
}
2222

23-
if ( deviceService.isMobile() ) { hideFooter(); }
23+
if ( deviceService.isMobile() ) { hideFooter(); } // Initially hide the footer on mobile devices
2424

2525
element.on('click', function() {
2626
if (animationInProgress) { return; }
@@ -38,4 +38,4 @@
3838

3939
}]);
4040

41-
})(angular || window.angular)
41+
})(angular || window.angular);

app/scripts/services/amenitiesService.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ angular.module('appServices').factory('amenitiesService', ['$http', '$q',
3232
}
3333
};
3434

35-
this.push(processed);
35+
activities.markers.push(processed);
3636
}
3737

3838
function generateActivityMarkers(response) {
3939
if (response.status === 200) {
40-
angular.forEach(response.data.features, extractIndividualActivity, activities.markers);
40+
angular.forEach(response.data.features, extractIndividualActivity);
4141
return activities.markers;
4242
} else {
4343
return logError();

app/scripts/services/deviceService.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
angular.module('appServices').factory('deviceService', ['$window', '$q',
44
function($window, $q){
55

6-
var _width = $window.innerWidth;
76
var activeToast = $q.defer();
87

98
function toastIsClosed() {
@@ -15,7 +14,7 @@ angular.module('appServices').factory('deviceService', ['$window', '$q',
1514
}
1615

1716
function isMobile() {
18-
return _width < 768;
17+
return $window.innerWidth < 768;
1918
}
2019

2120
function scrollTo(target) {

app/scripts/services/googleMaps.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
if (_isGooglePresent()) {
3636
deferred.resolve(google.maps || window.google.maps);
3737
}
38-
}
38+
};
3939

4040
}]);
4141

app/scripts/services/parkService.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -84,9 +84,9 @@
8484
};
8585

8686
// Storing parks both individually as key on markers object and as an array of parks
87-
if (!this[marker.urlFormat]) { this[marker.urlFormat] = marker; }
87+
if (!parks[marker.urlFormat]) { parks[marker.urlFormat] = marker; }
8888

89-
this.markers.push(marker);
89+
parks.markers.push(marker);
9090
}
9191

9292

@@ -97,7 +97,7 @@
9797
parks.markers.splice(0, parks.markers.length);
9898
}
9999
// Make markers from the response data
100-
angular.forEach(response.data.features, extractIndividualMarker, parks);
100+
angular.forEach(response.data.features, extractIndividualMarker);
101101
// Return an array of markers in case we chain the promise
102102
return parks.markers;
103103
} else {

0 commit comments

Comments
 (0)