Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daytona server start health check doesn't wait for everything to start #1357

Open
Tpuljak opened this issue Nov 21, 2024 · 16 comments
Open

Daytona server start health check doesn't wait for everything to start #1357

Tpuljak opened this issue Nov 21, 2024 · 16 comments
Labels
bug Something isn't working never stale An issue that never goes stale ⚔️ Quest Tracks quest-bot quests

Comments

@Tpuljak
Copy link
Member

Tpuljak commented Nov 21, 2024

Describe the bug
The daytona server process only waits for the API server to start before exiting the command. This is problematic because the startup process also includes booting up the providers, the local registry and the headscale server which might fail or not be up soon enough for the user to interact with.

To Reproduce
Steps to reproduce the behavior:

  1. Run daytona server -y && daytona provider ls
  2. Observe that no providers are listed
  3. Wait a few seconds
  4. daytona provider ls
  5. Observe that providers are present not

Expected behavior
The daytona server command should make sure that all the components have started successfully before exiting the command. This will ensure that the user is fully informed about the state of the server upon completion.

Desktop (please complete the following information):

  • OS: any
  • Daytona Version: v0.45.0
@Tpuljak
Copy link
Member Author

Tpuljak commented Nov 25, 2024

@quest-bot stash 40

Copy link

quest-bot bot commented Nov 25, 2024

New Quest! image New Quest!

A new Quest has been launched in @daytonaio’s repo.
Merge a PR that solves this issue to loot the Quest and earn your reward.


Loot of 40 USD has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #1357 to link your PR to this Quest.

Questions? Check out the docs.


👉 If no one is assigned to the issue, you are welcome to embark on the quest and tackle it without confirmation from us. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Nov 25, 2024
@Freedisch
Copy link

I will take a look at it

@Freedisch
Copy link

@quest-bot embark

Copy link

quest-bot bot commented Nov 25, 2024

@Freedisch has embarked on their Quest. 🗡

  • @Freedisch has been on GitHub since 2021.
  • They have merged 79 public PRs in that time.
  • Their swords are blessed with Dockerfile and Shell magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@Ximax80
Copy link

Ximax80 commented Nov 25, 2024

embark

@Ximax80
Copy link

Ximax80 commented Nov 26, 2024

@quest-bot loot #1357

Copy link

quest-bot bot commented Nov 26, 2024

⚠️ Oops... You can only loot in a Pull Request!

Check the docs for more info.

Copy link

quest-bot bot commented Nov 26, 2024

🧚 @Ximax80 has submitted PR #1371 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @Freedisch

Questions? Check out the docs.

@naaa760
Copy link

naaa760 commented Nov 26, 2024

@quest-bot embark

Copy link

quest-bot bot commented Nov 26, 2024

@naaa760 has embarked on their Quest. 🗡

  • @naaa760 has been on GitHub since 2024.
  • They have merged 4 public PRs in that time.
  • Their swords are blessed with JavaScript and TypeScript magic ✨
  • They haven't contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

@Freedisch
Copy link

@Tpuljak
I have run different tests to reproduce the error on the latest build of daytona, and providers are always being listed when running either
daytona server -y && daytona provider ls or daytona provider ls

I'm going to run the tests with more components

Screenshot 2024-12-03 at 19 20 54

System: Darwin arm64

@Tpuljak
Copy link
Member Author

Tpuljak commented Dec 3, 2024

@Freedisch it fails for me basically every time. Maybe try by installing more providers first (daytona provider install)

@Tpuljak Tpuljak added the never stale An issue that never goes stale label Dec 5, 2024
@tarunrajput
Copy link
Contributor

@quest-bot embark

Copy link

quest-bot bot commented Dec 5, 2024

@tarunrajput has embarked on their Quest. 🗡

  • @tarunrajput has been on GitHub since 2017.
  • They have merged 93 public PRs in that time.
  • Their swords are blessed with JavaScript and CSS magic ✨
  • They have contributed to this repo before.

This is not an assignment to the issue. Please check the repo’s contribution guidelines before submitting a PR.

Questions? Check out the docs.

Copy link

quest-bot bot commented Dec 5, 2024

🧚 @tarunrajput has submitted PR #1419 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

cc @Freedisch
@Ximax80
@naaa760

Questions? Check out the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working never stale An issue that never goes stale ⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants