Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaks if physdim metadata embedded in or referenced by info.json instead of manifest.json #2

Open
markmatney opened this issue Apr 7, 2017 · 0 comments

Comments

@markmatney
Copy link

markmatney commented Apr 7, 2017

Per the IIIF services annex document, there are four ways to include physical dimension metadata:

  1. embedded in manifest.json
  2. as a separate resource, referenced by manifest.json
  3. embedded in info.json
  4. as a separate resource, referenced by info.json

The problem is that right now, the ImageView module of Mirador doesn't export the info.json metadata after it is fetched; it just uses the metadata internally to instantiate an instance of OpenSeadragon, and then throws the metadata away. So right now it is impossible to modify this plugin to support options 3) and 4) above without making custom modifications to the Mirador source code.

My solution requires two steps:

  • somewhere in that callback function declared on line 540, set a property on _this (the ImageView object) that exports the value of the infoJson local variable (e.g., _this.currentInfoJson = infoJson;)
  • change this line to var service = _this.currentImg.service || _this.currentInfoJson.service;

I will open a related issue on the Mirador project, and will reference it here.

ProjectMirador/mirador#1378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant