Skip to content

[Bug] [spike] Wrong commit used for core testing #104

@emmyoop

Description

@emmyoop

Is this a new bug in dbt-common?

  • I believe this is a new bug in dbt-common
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

When we put a PR into the merge queue it uses the wrong commit on dbt_common to run tests against. This is because tox reinstalls all dependencies so overriding the dep isn't working as written.

Expected Behavior

Use the temporary merge commit to run tests to mock the state after merge

Steps To Reproduce

  1. Open a Pr
  2. Add PR to merge queue
  3. observe the commit checked out for dbt-common in PR

Relevant log output

No response

Additional Context

No response

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtech_debtBehind-the-scenes changes, with little direct impact on end-user functionality

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions