Prevent overcounting PropertyMovedToConfigDeprecation for source freshness

[graciegoheen]

Current Behavior

if i have freshness defined for 1 source (4 tables)

version: 2

sources:
  - name: raw
    database: raw
    schema: magic_shop
    freshness:
      warn_after:
        count: 24
        period: hour
    loaded_at_query: "select current_timestamp()"
    tables:
      - name: wizards
      - name: orders
      - name: wands
      - name: worlds

when i run dbt parse --no-partial-parse --show-all-deprecations i see 4 deprecations listed (all to the same file):

22:05:29 [WARNING]: Deprecated functionality
Found `freshness` as a top-level property of `raw` in file
`models/staging/sources.yml`. The `freshness` top-level property should be moved
into the `config` of `raw`.
22:05:29 [WARNING]: Deprecated functionality
Found `freshness` as a top-level property of `raw` in file
`models/staging/sources.yml`. The `freshness` top-level property should be moved
into the `config` of `raw`.
22:05:29 [WARNING]: Deprecated functionality
Found `freshness` as a top-level property of `raw` in file
`models/staging/sources.yml`. The `freshness` top-level property should be moved
into the `config` of `raw`.  

and the summary:

22:05:29 [WARNING]: Deprecated functionality
Summary of encountered deprecations:
- PropertyMovedToConfigDeprecation: 4 occurrences

Expected Behavior

i feel like this should only be 1 instance of the deprecated functionality not 4 - this is inflating length of logs and # of occurrences of deprecation

[QMalcolm]

Ahhh the issue here is that this deprecation is being fired at the point of merging freshness definitions on the source/table itself when creating the table node. Ideally we would be only firing this deprecation on JSONSchema validation, but we haven't enabled that yet.

[graciegoheen]

Ideally we would be only firing this deprecation on JSONSchema validation

agree that we should do this instead!

[fivetran-jamie]

Hey hey @graciegoheen! Someone opened an issue on one of our repos to resolve the Found freshness as a top-level property of... deprecation message.

Is this ticket to totally get rid of that, or just to consolidate deprecation messages? If it's the latter, where should we put freshness configs now? Or is the issue how we have the count and period set?

Thanks, appreciate any help 🤠

----- update -----
Ah just came across #11506 and now see how freshness is supposed to be set

[graciegoheen]

hi @fivetran-jamie ! Yep - this ticket is just to consolidate the number of deprecation warnings, but we are moving freshness under config (so that folks can set project / folder level defaults) - here is the docs for the deprecation warning folks are likely seeing.

We backported the ability to set freshness as a config to 1.9 as well, though the deprecation warning will only be emitted starting in 1.10. And the new dbt fusion engine will only support freshness as a config.

What I'm doing for dbt_project_evaluator is:

• moving freshness under config
• setting require-dbt-version to be >=1.9.0

Let me know if you need any help!

[fivetran-jamie]

@graciegoheen Oooh does this mean people can configure freshness in their dbt_project.yml? Thanks!