Skip to content

Commit bda1ad0

Browse files
committed
better order of canceling job scheduler's jobs and pool's jobs, so we're sure no new job get scheduled to the pool if update() happens to be running concurrently
1 parent 5665f1e commit bda1ad0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/gazeMapper/GUI/_impl/process_pool.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -213,11 +213,11 @@ def cancel_job(self, job_id: int):
213213

214214
def cancel_all_jobs(self):
215215
# cancel any jobs that may still be running
216-
self._pool.cancel_all_jobs()
217-
# make double sure they're cancelled
218216
for job_id in self.jobs:
219217
if self.jobs[job_id]._final_state not in [process.State.Completed, process.State.Canceled, process.State.Failed]:
220218
self.cancel_job(job_id)
219+
# make double sure they're cancelled
220+
self._pool.cancel_all_jobs()
221221
# ensure pool is no longer running
222222
self._pool.cleanup()
223223

0 commit comments

Comments
 (0)