Skip to content

Commit c4c87ab

Browse files
committed
Add summary table ID
1 parent 9cd9d85 commit c4c87ab

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

mlip_testing/app/build_app.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def build_summary_table(tables: dict[str, DataTable]) -> DataTable:
7676
columns_headers = ("MLIP",) + tuple(tables.keys()) + ("Score", "Rank")
7777
columns = [{"name": headers, "id": headers} for headers in columns_headers]
7878

79-
return DataTable(data=data, columns=columns)
79+
return DataTable(data=data, columns=columns, id="summary-table")
8080

8181

8282
def build_tabs(
@@ -152,6 +152,6 @@ def build_full_app(full_app: Dash) -> None:
152152
header="Benchmark weights",
153153
labels=tables.keys(),
154154
ids=tables.keys(),
155-
reset_prefix="summary",
155+
table_prefix="summary",
156156
)
157157
build_tabs(full_app, layouts, summary_table, weight_components)

mlip_testing/app/utils/build.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,16 @@ def build_slider(
6363
)
6464

6565

66-
def register_weight_callbacks(weight_prefix: str, reset_prefix: str) -> None:
66+
def register_weight_callbacks(weight_prefix: str, table_prefix: str) -> None:
6767
"""
6868
Register all callbacks for weight inputs.
6969
7070
Parameters
7171
----------
7272
weight_prefix
7373
Prefix for weight component IDs.
74-
reset_prefix
75-
Prefix for reset component ID.
74+
table_prefix
75+
Prefix for table and reset component ID.
7676
"""
7777

7878
# Callback to sync weights between slider, text, reset, and Store
@@ -83,7 +83,7 @@ def register_weight_callbacks(weight_prefix: str, reset_prefix: str) -> None:
8383
Input(f"{weight_prefix}-input", "value"),
8484
Input(f"{weight_prefix}-slider", "value"),
8585
Input(f"{weight_prefix}-weight-store", "data"),
86-
Input(f"{reset_prefix}-reset-weights-button", "n_clicks"),
86+
Input(f"{table_prefix}-reset-weights-button", "n_clicks"),
8787
prevent_initial_call=False,
8888
)
8989
def store_slider_value(
@@ -116,15 +116,15 @@ def store_slider_value(
116116
weight = input_value
117117
elif trigger_id == f"{weight_prefix}-slider":
118118
weight = slider_value
119-
elif trigger_id == f"{reset_prefix}-reset-weights-button":
119+
elif trigger_id == f"{table_prefix}-reset-weights-button":
120120
weight = 1
121121
else:
122122
raise ValueError("Invalid trigger. trigger_id: ", trigger_id)
123123
return weight, weight, weight
124124

125125

126126
def build_weight_components(
127-
header: str, labels: list[str], ids: list[str], reset_prefix: str
127+
header: str, labels: list[str], ids: list[str], table_prefix: str
128128
) -> Div:
129129
"""
130130
Build weight sliders, text boxes and reset button.
@@ -137,8 +137,8 @@ def build_weight_components(
137137
Names for each weight slider.
138138
ids
139139
Prefix for slider and input box IDs.
140-
reset_prefix
141-
Label for reset button used for all weights.
140+
table_prefix
141+
Label for table and reset button used for all weights.
142142
143143
Returns
144144
-------
@@ -160,7 +160,7 @@ def build_weight_components(
160160
layout.append(
161161
Button(
162162
"Reset Weights",
163-
id=f"{reset_prefix}-reset-weights-button",
163+
id=f"{table_prefix}-reset-weights-button",
164164
n_clicks=0,
165165
style={"marginTop": "20px"},
166166
),
@@ -170,7 +170,7 @@ def build_weight_components(
170170
layout.append(
171171
Store(id=f"{weight_prefix}-weight-store", storage_type="session", data=1.0)
172172
)
173-
register_weight_callbacks(weight_prefix, reset_prefix)
173+
register_weight_callbacks(weight_prefix, table_prefix)
174174

175175
return Div(layout)
176176

0 commit comments

Comments
 (0)