Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: move core-kernel dependency to devDependencies #14

Open
e-m-s-y opened this issue Sep 17, 2021 · 0 comments
Open

Suggestion: move core-kernel dependency to devDependencies #14

e-m-s-y opened this issue Sep 17, 2021 · 0 comments

Comments

@e-m-s-y
Copy link

e-m-s-y commented Sep 17, 2021

Hey rsk,

I noticed that @arkecosystem/core-kernel is in your dependency list -> https://github.com/deadlock-delegate/notifier/blob/master/package.json#L35

I think this will break your plugin when running it on relay with core version > next.35. In this case your plugin will use a different version of core-kernel rather than the actual one the relay uses, however I'm not 100% sure on this. My suggestion is to move core-kernel to your devDependencies instead. I had similar issues with this in the past and now that next.36 is released it might be worth looking into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant