From 0027bad7397ac3df9b5ab719ef7b94031cf8e351 Mon Sep 17 00:00:00 2001 From: Alexandru Emil Lupu Date: Wed, 25 Sep 2024 09:39:39 +0300 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Andrés Pereira de Lucena --- exe/decidim-action-backporter | 2 +- lib/decidim/maintainers_toolbox/action_backporter.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exe/decidim-action-backporter b/exe/decidim-action-backporter index 914f88f..068ae91 100755 --- a/exe/decidim-action-backporter +++ b/exe/decidim-action-backporter @@ -7,7 +7,7 @@ require_relative "../lib/decidim/maintainers_toolbox/github_manager/querier" require_relative "../lib/decidim/maintainers_toolbox/action_backporter" class ActionBackporterCLI < Thor - desc "", "Backport a pull request to another branch" + desc "", "Backport a pull request to another branch. This is intended to be run in the GitHub Action environment, for automating the backport processes." option :github_token, required: true, desc: <<~HELP Required. Github Personal Access Token (PAT). It can be obtained from https://github.com/settings/tokens/new. You will need to create one with `public_repo` access. Alternatively, you can use the `gh` CLI tool to authenticate with `gh auth token` (i.e. --github-token=$(gh auth token)) diff --git a/lib/decidim/maintainers_toolbox/action_backporter.rb b/lib/decidim/maintainers_toolbox/action_backporter.rb index 8c3beb0..a5ba126 100644 --- a/lib/decidim/maintainers_toolbox/action_backporter.rb +++ b/lib/decidim/maintainers_toolbox/action_backporter.rb @@ -36,7 +36,7 @@ def call attr_reader :token, :pull_request_id, :exit_with_unstaged_changes - def create_backport_task(version) + def create_backport_issue(version) some_params = { title: "Fail: automatic backport of \"#{pull_request_metadata[:title]}\"", body: "Automatic backport of ##{pull_request_id} has failed for version #{version}. Please do this action manually.",