Find attributes in resource from extends

[valentinrougier39]

Hi, I use resources which are extended, when project Resource is extended but not overloaded, I don't have attributes in doc.
Exemple : I have a DogResource in my project but I extend this class from a package with DogPackageResource in DogPackageResource the method toArray() is ready and If I don't overload it, the doc is empty.
Is a possibility of improvement ?
Thank you

[romalytvynenko]

@valentinrougier39 I think I get the question, but still if you share some code examples I'd appreciate it

[romalytvynenko]

Hey hey! Added the issue: #505

[romalytvynenko]

@valentinrougier39 To be honest, after trying it out, I don't think this really fits into the core, so here is the extension you can try:

<?php

namespace Dedoc\Scramble\Support\InferExtensions;

use Dedoc\Scramble\Infer;
use Dedoc\Scramble\Infer\Extensions\AfterClassDefinitionCreatedExtension;
use Dedoc\Scramble\Infer\Extensions\Event\ClassDefinitionCreatedEvent;
use Illuminate\Http\Resources\Json\JsonResource;
use Illuminate\Support\Str;

class AnalyzeVendorJsonResourcesExtension implements AfterClassDefinitionCreatedExtension
{
    public function shouldHandle(string $name): bool
    {
        return is_a($name, JsonResource::class, true) && $name !== JsonResource::class;
    }

    public function afterClassDefinitionCreated(ClassDefinitionCreatedEvent $event)
    {
        if (! $this->isClassInVendor($event->name)) {
            return;
        }

        app(Infer::class)->analyzeClass($event->name);
    }

    private function isClassInVendor(string $className): bool
    {
        $filePath = (new \ReflectionClass($className))->getFileName();

        return Str::contains($filePath, DIRECTORY_SEPARATOR.'vendor'.DIRECTORY_SEPARATOR);
    }
}

[romalytvynenko]

It works by enforcing analysis of json resource files from vendor, after they've been skipped due to being a vendor files

[romalytvynenko]

I may reconsider this and add it to core, if you share the package you use (that one that has JsonResources in it). I'm simply not sure that analyzing that files will solve the issue – maybe they have some magic in toArray, I don't know.

[valentinrougier39]

Hi @romalytvynenko , thank you, I'll try this soon