Skip to content

Remove outdated test and fix migration to make build green again #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove outdated test and fix migration to make build green again #1151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c022fa
Remove outdated test
amritpurshotam Jul 29, 2023
2f53274
Fix migrations
amritpurshotam Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions api/app/invoice/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,17 +548,6 @@ def __init__(self, *args, **kwargs):

def setUp(self):
super().setUp()

def test_prevent_paying_wrong_invoice(self):
line_items = self.get_default_line_items()
invoice = self.add_invoice(self.treasurer_id, self.treasurer_id, line_items, self.treasurer_email)
invoice_id = invoice.id

header = self.get_auth_header_for(self.applicant_email)
params = {'invoice_id': invoice_id}
response = self.app.post(self.url, headers=header, data=params)

self.assertEqual(response.status_code, INVOICE_NOT_FOUND[1])

def test_prevent_pay_invoice_again(self):
line_items = self.get_default_line_items()
Expand Down
4 changes: 2 additions & 2 deletions api/migrations/versions/5d5b0524b4fa_add_parent_id_to_response.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
"""
Revision ID: 5d5b0524b4fa
Revises: 627a96dad7e8
Revises: 0edb89e87e72
Create Date: 2023-05-27 07:46:16.735763

"""

# revision identifiers, used by Alembic.
revision = '5d5b0524b4fa'
down_revision = '627a96dad7e8'
down_revision = '0edb89e87e72'

from alembic import op
import sqlalchemy as sa
Expand Down
23 changes: 0 additions & 23 deletions api/migrations/versions/9143756e596d_merge_parent_id_and_offer_email_templates.py
View file
Open in desktop

This file was deleted.