-
Notifications
You must be signed in to change notification settings - Fork 38
Added is_private field to Review Response table #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucas-meyer-7
wants to merge
9
commits into
develop
Choose a base branch
from
db_review_response_private_field
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1c022fa
Remove outdated test
amritpurshotam 2f53274
Fix migrations
amritpurshotam 6d68baf
Added is_private field to Review Response table
lucas-meyer-7 54db003
Fixed migration and updated mixins
lucas-meyer-7 5195f2e
Merge branch 'fix/payment-test' into db_review_response_private_field
lucas-meyer-7 180610d
Fixed migration
lucas-meyer-7 d9f32db
Fixed tests containing ReviewResponse
lucas-meyer-7 858d037
Fixed one of the tests
lucas-meyer-7 65c5f9a
Fixed the rest of the ReviewApi tests
lucas-meyer-7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
api/migrations/versions/e23b638b03cc_add_is_private_to_review_response.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| """ | ||
| Adds a field called ``is_private`` to review_response table. | ||
| It is used to specify whether the response from the reviewer is public, | ||
| or private. If it is private, then only the meta-reviewer can see the response. | ||
| Revision ID: e23b638b03cc | ||
| Revises: 9143756e596d | ||
| Create Date: 2023-07-30 19:16:28.509240 | ||
| """ | ||
|
|
||
| # revision identifiers, used by Alembic. | ||
| revision = 'e23b638b03cc' | ||
| down_revision = '9143756e596d' | ||
|
|
||
| from alembic import op | ||
| import sqlalchemy as sa | ||
|
|
||
| def upgrade(): | ||
| op.add_column('review_response', sa.Column('is_private', sa.Boolean(), nullable=False)) | ||
lucas-meyer-7 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| def downgrade(): | ||
| op.drop_column('review_response', 'is_private') | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.