Skip to content

DESK_REJECT added #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

DESK_REJECT added #1285

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a8a1314
Added DESK_REJECT
umair-nasir14 Sep 16, 2024
b887a91
Desk reject email template + migrations updates
umair-nasir14 Sep 16, 2024
97dde8b
Textbox added
umair-nasir14 Sep 16, 2024
afd9bf1
outcome api enum fix + migrations
umair-nasir14 Sep 21, 2024
149e845
Code cleanup
umair-nasir14 Oct 8, 2024
0c01a8c
Editors note added
umair-nasir14 Oct 22, 2024
6a2668a
Review rendering bugfix
umair-nasir14 Oct 23, 2024
84cdd76
Rendering fix
umair-nasir14 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions api/app/outcome/api.py
View file
Open in desktop
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up. I think there is no other print statement that would go in prod.

Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ def post(self, event_id):

outcome_repository.add(outcome)
db.session.commit()
print("event_type::::::::", event.event_type)
print("Type of event.event_type:::::::", type(event.event_type))
if status in [Status.REJECTED, Status.WAITLIST, Status.DESK_REJECTED]:
email_template = {
Status.REJECTED: 'outcome-rejected' if not event.event_type == EventType.JOURNAL else 'outcome-journal-rejected',
Expand Down