Skip to content

Commit 966c435

Browse files
authored
forkdiff update (ethereum-optimism#321)
* forkdiff update * update forkdiff version, rename ignore field to match forkdiff change
1 parent 3fbae78 commit 966c435

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

.github/workflows/pages.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
fetch-depth: 1000 # make sure to fetch the old commit we diff against
1717

1818
- name: Build forkdiff
19-
uses: "docker://protolambda/forkdiff:latest"
19+
uses: "docker://protolambda/forkdiff:0.1.0"
2020
with:
2121
args: -repo=/github/workspace -fork=/github/workspace/fork.yaml -out=/github/workspace/index.html
2222

fork.yaml

+18-5
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ footer: |
55
base:
66
name: go-ethereum
77
url: https://github.com/ethereum/go-ethereum
8-
hash: c5ba367eb6232e3eddd7d6226bfd374449c63164 v1.13.15
8+
hash: c5ba367eb6232e3eddd7d6226bfd374449c63164 # v1.13.15
99
fork:
1010
name: op-geth
1111
url: https://github.com/ethereum-optimism/op-geth
@@ -56,7 +56,7 @@ def:
5656
globs:
5757
- "core/vm/evm.go"
5858
- "core/evm.go"
59-
- "core/types/rollup_l1_cost.go"
59+
- "core/types/rollup_cost.go"
6060
- "core/state_processor.go"
6161
- "core/state_prefetcher.go"
6262
- title: Transaction processing
@@ -111,7 +111,7 @@ def:
111111
description: |
112112
Transaction queueing and inclusion needs to account for the L1 cost component.
113113
globs:
114-
- "core/txpool/*"
114+
- "core/txpool/**/*"
115115
- "core/txpool/legacypool/*"
116116
- title: "Chain Configuration"
117117
sub:
@@ -188,6 +188,10 @@ def:
188188
description: Fix discv5 option to allow discv5 to be an active source for node-discovery.
189189
globs:
190190
- "p2p/server.go"
191+
- title: Bootnodes
192+
description: Discovery bootnode addresses.
193+
globs:
194+
- "params/bootnodes.go"
191195
- title: Generated TOML config update
192196
globs:
193197
- "eth/ethconfig/gen_config.go"
@@ -222,7 +226,7 @@ def:
222226
globs:
223227
- "eth/tracers/api.go"
224228
- title: "Daisy Chain tests"
225-
globs:
229+
ignore:
226230
- "internal/ethapi/transaction_args_test.go"
227231
- "ethclient/ethclient_test.go"
228232
- "eth/tracers/api_test.go"
@@ -255,11 +259,20 @@ def:
255259
# upstream PR: https://github.com/ethereum/go-ethereum/pull/28863/
256260
globs:
257261
- "accounts/usbwallet/hub.go"
262+
- title: "Testing"
263+
description: Additional or modified tests, not already captured by the above diff
264+
ignore:
265+
- "**/*_test.go"
258266

259267
# ignored globally, does not count towards line count
260268
ignore:
261269
- ".circleci/*"
262270
- "*.sum"
263271
- "go.mod"
264272
- "fork.yaml"
265-
- ".github/*"
273+
- "Makefile"
274+
- ".golangci.yml"
275+
- ".github/**"
276+
- "**/*.gob" # data asset, not code
277+
- "core/vm/testdata/precompiles/p256Verify.json" # data asset, not code
278+
- "eth/tracers/internal/tracetest/testdata/**/*.json"

0 commit comments

Comments
 (0)