Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the compute calculation wrong for Chinchilla in the paper? #48

Open
yzlnew opened this issue Apr 30, 2024 · 1 comment
Open

Is the compute calculation wrong for Chinchilla in the paper? #48

yzlnew opened this issue Apr 30, 2024 · 1 comment

Comments

@yzlnew
Copy link

yzlnew commented Apr 30, 2024

From the paper, Eq.2 list Chinchilla compute calculation as

$$6N_2 = 72 n_\text{layer}d_\text{model}^2 + 6n_\text{vocab}d_\text{model}$$

The first term comes from the $6ND$ estimate for non-embedding FLOPs (exclude lm_head parameters as well, maybe because of the tied embeddings), but the second term is not what Chinchilla used to calculate embedding FLOPs, see Appendix F from the Chinchilla paper, total forward pass FLOPs include embeddings and logits calculations.

So, $N_2$ should be larger than what is used in the paper (double the second term)?

@yzlnew yzlnew changed the title Is the model scale representation identical to Chinchilla? Is the compute calculation wrong for Chinchilla in the paper? Apr 30, 2024
@yzlnew
Copy link
Author

yzlnew commented Apr 30, 2024

Starting from Table 3, I re-add the missing part to $N_2$ and recalculate $6N_2/M$, the results are [2.19, 1.50, 1.01, 1.01, 0.97, 0.95, 0.95], which is much closer to 1.0 for larger models.

Could you share the data of Figure 6 for further study? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant