Skip to content

Commit 3eba7b9

Browse files
author
moebius
committed
perf: delete response improvement
1 parent dd83db0 commit 3eba7b9

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

solidity/contracts/Oracle.sol

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -206,8 +206,8 @@ contract Oracle is IOracle {
206206

207207
/// @inheritdoc IOracle
208208
function deleteResponse(bytes32 _responseId) external {
209-
Response memory _response = _responses[_responseId];
210-
Request memory _request = _requests[_response.requestId];
209+
Response storage _response = _responses[_responseId];
210+
Request storage _request = _requests[_response.requestId];
211211

212212
if (disputeOf[_responseId] != bytes32(0)) {
213213
revert Oracle_CannotDeleteWhileDisputing(_responseId);
@@ -217,11 +217,10 @@ contract Oracle is IOracle {
217217
}
218218

219219
_request.responseModule.deleteResponse(_response.requestId, _responseId, msg.sender);
220-
221-
delete _responses[_responseId];
222220
_responseIds[_response.requestId].remove(_responseId);
223221

224222
emit ResponseDeleted(_response.requestId, msg.sender, _responseId);
223+
delete _responses[_responseId];
225224
}
226225

227226
/// @inheritdoc IOracle

0 commit comments

Comments
 (0)