Skip to content

Commit c3961c9

Browse files
author
Nick Lanham
committed
Merge remote-tracking branch 'upstream/main' into fix-out-of-date-last-checkpoint
2 parents a4fc54f + e88ae2d commit c3961c9

File tree

6 files changed

+523
-239
lines changed

6 files changed

+523
-239
lines changed

acceptance/src/data.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use crate::{TestCaseInfo, TestResult};
1515
pub async fn read_golden(path: &Path, _version: Option<&str>) -> DeltaResult<RecordBatch> {
1616
let expected_root = path.join("expected").join("latest").join("table_content");
1717
let store = Arc::new(LocalFileSystem::new_with_prefix(&expected_root)?);
18-
let files = store.list(None).try_collect::<Vec<_>>().await?;
18+
let files: Vec<_> = store.list(None).try_collect().await?;
1919
let mut batches = vec![];
2020
let mut schema = None;
2121
for meta in files.into_iter() {

ffi/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ pub enum KernelError {
328328
InvalidStructDataError,
329329
InternalError,
330330
InvalidExpression,
331+
InvalidLogPath,
331332
}
332333

333334
impl From<Error> for KernelError {
@@ -374,6 +375,7 @@ impl From<Error> for KernelError {
374375
backtrace: _,
375376
} => Self::from(*source),
376377
Error::InvalidExpressionEvaluation(_) => KernelError::InvalidExpression,
378+
Error::InvalidLogPath(_) => KernelError::InvalidLogPath,
377379
}
378380
}
379381
}

kernel/src/error.rs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,10 @@ pub enum Error {
155155
/// Expressions did not parse or evaluate correctly
156156
#[error("Invalid expression evaluation: {0}")]
157157
InvalidExpressionEvaluation(String),
158+
159+
/// Unable to parse the name of a log path
160+
#[error("Invalid log path: {0}")]
161+
InvalidLogPath(String),
158162
}
159163

160164
// Convenience constructors for Error types that take a String argument
@@ -203,6 +207,9 @@ impl Error {
203207
pub fn invalid_expression(msg: impl ToString) -> Self {
204208
Self::InvalidExpressionEvaluation(msg.to_string())
205209
}
210+
pub(crate) fn invalid_log_path(msg: impl ToString) -> Self {
211+
Self::InvalidLogPath(msg.to_string())
212+
}
206213

207214
pub fn internal_error(msg: impl ToString) -> Self {
208215
Self::InternalError(msg.to_string()).with_backtrace()

kernel/src/lib.rs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,12 @@ pub mod engine_data;
6363
pub mod error;
6464
pub mod expressions;
6565
pub mod features;
66+
67+
#[cfg(feature = "developer-visibility")]
68+
pub mod path;
69+
#[cfg(not(feature = "developer-visibility"))]
6670
pub(crate) mod path;
71+
6772
pub mod scan;
6873
pub mod schema;
6974
pub mod snapshot;

0 commit comments

Comments
 (0)