chore: remove lazy_static in favor of LazyLock #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hntd187
requested review from
nicklan,
scovich,
zachschuermann and
OussamaSaoudi-db
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
==========================================
+ Coverage 74.71% 74.89% +0.17%
==========================================
Files 43 43
Lines 8361 8409 +48
Branches 8361 8409 +48
==========================================
+ Hits 6247 6298 +51
+ Misses 1727 1724 -3
Partials 387 387 ☔ View full report in Codecov by Sentry. |
scovich
approved these changes
Sep 30, 2024
Co-authored-by: Ryan Johnson <[email protected]>
|
A checkout reverted my removal of the crate, we should be good to go now. |
nicklan
pushed a commit
to nicklan/delta-kernel-rs
that referenced
this pull request
Oct 2, 2024
Turns out we don't use lazy static in many places so potentially removing the dependency is straight forward. Lazy static itself even gives an example from the standard library. https://github.com/rust-lang-nursery/lazy-static.rs?tab=readme-ov-file#standard-library --------- Co-authored-by: Ryan Johnson <[email protected]>
nicklan
added a commit
to nicklan/delta-kernel-rs
that referenced
this pull request
Oct 2, 2024
This reverts commit 0968281.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we don't use lazy static in many places so potentially removing the dependency is straight forward. Lazy static itself even gives an example from the standard library.
https://github.com/rust-lang-nursery/lazy-static.rs?tab=readme-ov-file#standard-library