Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some typos #643

Merged
merged 1 commit into from
Jan 14, 2025
Merged

chore: fix some typos #643

merged 1 commit into from
Jan 14, 2025

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Jan 14, 2025

What changes are proposed in this pull request?

Recently installed a spell checker in my IDE and thought I'd fix the findings ...

How was this change tested?

current tests, no changes to code / logic.

Signed-off-by: Robert Pack <[email protected]>
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (350d5b2) to head (6c61dcb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kernel/src/engine/default/parquet.rs 50.00% 2 Missing ⚠️
kernel/src/engine/sync/parquet.rs 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #643      +/-   ##
==========================================
- Coverage   83.45%   83.45%   -0.01%     
==========================================
  Files          75       75              
  Lines       16919    16918       -1     
  Branches    16919    16918       -1     
==========================================
- Hits        14120    14119       -1     
  Misses       2145     2145              
  Partials      654      654              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zachschuermann zachschuermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks robert!!

Copy link
Collaborator

@scovich scovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. I'm pretty sure some of those sepilign errors were mine 😛

@roeap roeap merged commit 12020d8 into delta-io:main Jan 14, 2025
20 of 22 checks passed
@roeap roeap deleted the fix/typos branch January 14, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants