feat(disable conflict checker): start counting concurrent retries at 0 and disable conflict checker with maxRetries=0

[daphnenhuch-at]

Description

Add behavior such that max_retries = 0 does not enable the conflict checker

Related Issue(s)

Closes #3186 3186

Documentation

n/a

[github-actions]

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

[daphnenhuch-at]

Question: When do you expect the next official release of deltalake to be released?

[codecov]

Codecov Report

Attention: Patch coverage is 93.47826% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.14%. Comparing base (b3efdfc) to head (cdd2610).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/core/src/operations/write.rs	92.30%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3204      +/-   ##
==========================================
+ Coverage   72.10%   72.14%   +0.03%     
==========================================
  Files         138      138              
  Lines       45320    45365      +45     
  Branches    45320    45365      +45     
==========================================
+ Hits        32678    32728      +50     
+ Misses      10567    10565       -2     
+ Partials     2075     2072       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ion-elgreco]

Looks good, can you add a test for this new behaviour please?

[daphnenhuch-at]

Added a test!

[ion-elgreco]

@daphnenhuch-at looks good, can you squash the commits into one please. Then we can merge it

[hntd187]

It's not clear to me why you would want disable the conflict checker. I don't have any issues with this PR, I'm more curious what the use case is.

[daphnenhuch-at]

It's not clear to me why you would want disable the conflict checker. I don't have any issues with this PR, I'm more curious what the use case is.

Our usage wants to disable any concurrent writes and that requires disabling the conflict checker and just erroring any time a conflicting/concurrent write occurs

[daphnenhuch-at]

This is good to go, could someone stamp it so that it's merge ready?

[ion-elgreco]

Thanks!

[daphnenhuch-at]

@ion-elgreco When is the next official delta lake release scheduled for?

[ion-elgreco]

@ion-elgreco When is the next official delta lake release scheduled for?

I hope to get the next python release out once my open PRs are merged

[daphnenhuch-at]

@ion-elgreco When is the next official delta lake release scheduled for?

I hope to get the next python release out once my open PRs are merged

What about a rust release?

[ion-elgreco]

@ion-elgreco When is the next official delta lake release scheduled for?

I hope to get the next python release out once my open PRs are merged

What about a rust release?

Not sure, @rtyler thoughts?