Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load cdf latest version #3218

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

ion-elgreco
Copy link
Collaborator

Description

The eq check was incorrect, should be only greater than.

Also found small bug in get_latest_version. It would return a version that might be invalid if the start version is not existent. Add a robustness check in there and one recursion loop, to start from -1. This will either result in the correct version or stay -1 an throw not a table location :)

Related Issue(s)

@ion-elgreco ion-elgreco force-pushed the fix/load_cdf_latest_version branch from c47ab43 to 14aa4e4 Compare February 14, 2025 19:02
@github-actions github-actions bot added binding/python Issues for the Python package binding/rust Issues for the Rust crate labels Feb 14, 2025
@ion-elgreco ion-elgreco force-pushed the fix/load_cdf_latest_version branch from 14aa4e4 to fb92039 Compare February 14, 2025 19:04
hntd187
hntd187 previously approved these changes Feb 14, 2025
Copy link
Collaborator

@hntd187 hntd187 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

hntd187
hntd187 previously approved these changes Feb 14, 2025
@ion-elgreco ion-elgreco force-pushed the fix/load_cdf_latest_version branch from bb42225 to d160dcc Compare February 14, 2025 20:18
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 98.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (d563e10) to head (d160dcc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/logstore/mod.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
+ Coverage   72.15%   72.16%   +0.01%     
==========================================
  Files         138      138              
  Lines       45365    45394      +29     
  Branches    45365    45394      +29     
==========================================
+ Hits        32731    32760      +29     
  Misses      10561    10561              
  Partials     2073     2073              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco added this pull request to the merge queue Feb 14, 2025
Merged via the queue into delta-io:main with commit 1befab9 Feb 14, 2025
26 checks passed
@ion-elgreco ion-elgreco deleted the fix/load_cdf_latest_version branch February 14, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_cdf can't read last version
2 participants