-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load cdf latest version #3218
fix: load cdf latest version #3218
Conversation
Signed-off-by: Ion Koutsouris <[email protected]>
c47ab43
to
14aa4e4
Compare
14aa4e4
to
fb92039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
fb92039
to
2bd95a3
Compare
2bd95a3
to
bb42225
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
bb42225
to
d160dcc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3218 +/- ##
==========================================
+ Coverage 72.15% 72.16% +0.01%
==========================================
Files 138 138
Lines 45365 45394 +29
Branches 45365 45394 +29
==========================================
+ Hits 32731 32760 +29
Misses 10561 10561
Partials 2073 2073 ☔ View full report in Codecov by Sentry. |
Description
The eq check was incorrect, should be only greater than.
Also found small bug in get_latest_version. It would return a version that might be invalid if the start version is not existent. Add a robustness check in there and one recursion loop, to start from -1. This will either result in the correct version or stay -1 an throw not a table location :)
Related Issue(s)
load_cdf
can't read last version #3165