Skip to content

Commit f00da44

Browse files
paalvibeknowitpaalvibe
authored andcommitted
black linting
1 parent f1daf9e commit f00da44

File tree

2 files changed

+20
-60
lines changed

2 files changed

+20
-60
lines changed

python/delta_sharing/_internal_auth.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -126,9 +126,7 @@ def parse_oauth_token_response(self, response: str) -> OAuthClientCredentials:
126126
# Parsing the response per oauth spec
127127
# https://datatracker.ietf.org/doc/html/rfc6749#section-5.1
128128
json_node = json.loads(response)
129-
if "access_token" not in json_node or not isinstance(
130-
json_node["access_token"], str
131-
):
129+
if "access_token" not in json_node or not isinstance(json_node["access_token"], str):
132130
raise RuntimeError("Missing 'access_token' field in OAuth token response")
133131
if "expires_in" not in json_node:
134132
raise RuntimeError("Missing 'expires_in' field in OAuth token response")
@@ -242,9 +240,7 @@ def _signed_jwt(self, jwt_header, jwt_claims):
242240

243241

244242
class OAuthClientCredentialsAuthProvider(AuthCredentialProvider):
245-
def __init__(
246-
self, oauth_client: OAuthClient, auth_config: AuthConfig = AuthConfig()
247-
):
243+
def __init__(self, oauth_client: OAuthClient, auth_config: AuthConfig = AuthConfig()):
248244
self.auth_config = auth_config
249245
self.oauth_client = oauth_client
250246
self.current_token: Optional[OAuthClientCredentials] = None
@@ -270,18 +266,14 @@ def maybe_refresh_token(self) -> OAuthClientCredentials:
270266
def needs_refresh(self, token: OAuthClientCredentials) -> bool:
271267
now = int(time.time())
272268
expiration_time = token.creation_timestamp + token.expires_in
273-
return (
274-
expiration_time - now < self.auth_config.token_renewal_threshold_in_seconds
275-
)
269+
return expiration_time - now < self.auth_config.token_renewal_threshold_in_seconds
276270

277271
def get_expiration_time(self) -> Optional[str]:
278272
return None
279273

280274

281275
class AuthCredentialProviderFactory:
282-
__oauth_auth_provider_cache: Dict[
283-
DeltaSharingProfile, OAuthClientCredentialsAuthProvider
284-
] = {}
276+
__oauth_auth_provider_cache: Dict[DeltaSharingProfile, OAuthClientCredentialsAuthProvider] = {}
285277

286278
@staticmethod
287279
def create_auth_credential_provider(profile: DeltaSharingProfile):

python/delta_sharing/tests/test_auth.py

Lines changed: 16 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@ def test_oauth_client_credentials_auth_provider_exchange_token():
7979
mock_session = MagicMock(spec=Session)
8080
mock_session.headers = MagicMock()
8181

82-
token = OAuthClientCredentials(
83-
"access-token", 3600, int(datetime.now().timestamp())
84-
)
82+
token = OAuthClientCredentials("access-token", 3600, int(datetime.now().timestamp()))
8583
oauth_client.client_credentials.return_value = token
8684

8785
provider.add_auth_header(mock_session)
@@ -104,9 +102,7 @@ def test_oauth_client_credentials_auth_provider_reuse_token():
104102
mock_session = MagicMock(spec=Session)
105103
mock_session.headers = MagicMock()
106104

107-
valid_token = OAuthClientCredentials(
108-
"valid-token", 3600, int(datetime.now().timestamp())
109-
)
105+
valid_token = OAuthClientCredentials("valid-token", 3600, int(datetime.now().timestamp()))
110106
provider.current_token = valid_token
111107

112108
provider.add_auth_header(mock_session)
@@ -132,9 +128,7 @@ def test_oauth_client_credentials_auth_provider_refresh_token():
132128
expired_token = OAuthClientCredentials(
133129
"expired-token", 1, int(datetime.now().timestamp()) - 3600
134130
)
135-
new_token = OAuthClientCredentials(
136-
"new-token", 3600, int(datetime.now().timestamp())
137-
)
131+
new_token = OAuthClientCredentials("new-token", 3600, int(datetime.now().timestamp()))
138132
provider.current_token = expired_token
139133
oauth_client.client_credentials.return_value = new_token
140134

@@ -166,9 +160,7 @@ def test_oauth_client_credentials_auth_provider_needs_refresh():
166160
)
167161
assert provider.needs_refresh(token_expiring_soon)
168162

169-
valid_token = OAuthClientCredentials(
170-
"valid-token", 600 + 10, int(datetime.now().timestamp())
171-
)
163+
valid_token = OAuthClientCredentials("valid-token", 600 + 10, int(datetime.now().timestamp()))
172164
assert not provider.needs_refresh(valid_token)
173165

174166

@@ -208,9 +200,7 @@ def test_basic_auth_provider_add_auth_header():
208200
session.headers = MagicMock()
209201
session.auth = MagicMock()
210202
provider.add_auth_header(session)
211-
session.post(
212-
"https://localhost/delta-sharing/", data={"grant_type": "client_credentials"}
213-
)
203+
session.post("https://localhost/delta-sharing/", data={"grant_type": "client_credentials"})
214204
assert session.auth == ("username", "password")
215205

216206

@@ -232,9 +222,7 @@ def test_factory_creation():
232222
username="username",
233223
password="password",
234224
)
235-
provider = AuthCredentialProviderFactory.create_auth_credential_provider(
236-
profile_basic
237-
)
225+
provider = AuthCredentialProviderFactory.create_auth_credential_provider(profile_basic)
238226
assert isinstance(provider, BasicAuthProvider)
239227

240228
profile_bearer = DeltaSharingProfile(
@@ -244,9 +232,7 @@ def test_factory_creation():
244232
bearer_token="token",
245233
expiration_time=(datetime.now() + timedelta(hours=1)).isoformat(),
246234
)
247-
provider = AuthCredentialProviderFactory.create_auth_credential_provider(
248-
profile_bearer
249-
)
235+
provider = AuthCredentialProviderFactory.create_auth_credential_provider(profile_bearer)
250236
assert isinstance(provider, BearerTokenAuthProvider)
251237

252238
profile_oauth = DeltaSharingProfile(
@@ -257,9 +243,7 @@ def test_factory_creation():
257243
client_id="clientId",
258244
client_secret="clientSecret",
259245
)
260-
provider = AuthCredentialProviderFactory.create_auth_credential_provider(
261-
profile_oauth
262-
)
246+
provider = AuthCredentialProviderFactory.create_auth_credential_provider(profile_oauth)
263247
assert isinstance(provider, OAuthClientCredentialsAuthProvider)
264248

265249
profile_pk = DeltaSharingProfile(
@@ -287,9 +271,7 @@ def test_oauth_auth_provider_reused():
287271
client_id="clientId",
288272
client_secret="clientSecret",
289273
)
290-
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(
291-
profile_oauth1
292-
)
274+
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_oauth1)
293275
assert isinstance(provider1, OAuthClientCredentialsAuthProvider)
294276

295277
profile_oauth2 = DeltaSharingProfile(
@@ -301,9 +283,7 @@ def test_oauth_auth_provider_reused():
301283
client_secret="clientSecret",
302284
)
303285

304-
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(
305-
profile_oauth2
306-
)
286+
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_oauth2)
307287

308288
assert provider1 == provider2
309289

@@ -317,9 +297,7 @@ def test_oauth_auth_provider_with_different_profiles():
317297
client_id="clientId",
318298
client_secret="clientSecret",
319299
)
320-
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(
321-
profile_oauth1
322-
)
300+
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_oauth1)
323301
assert isinstance(provider1, OAuthClientCredentialsAuthProvider)
324302

325303
profile_oauth2 = DeltaSharingProfile(
@@ -331,9 +309,7 @@ def test_oauth_auth_provider_with_different_profiles():
331309
client_secret="clientSecret",
332310
)
333311

334-
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(
335-
profile_oauth2
336-
)
312+
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_oauth2)
337313

338314
assert provider1 != provider2
339315

@@ -351,9 +327,7 @@ def test_oauth_private_key_auth_provider_reused():
351327
scope="scope",
352328
audience="audience",
353329
)
354-
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(
355-
profile_pk1
356-
)
330+
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_pk1)
357331
assert isinstance(provider1, OAuthClientCredentialsAuthProvider)
358332

359333
profile_pk2 = DeltaSharingProfile(
@@ -368,9 +342,7 @@ def test_oauth_private_key_auth_provider_reused():
368342
scope="scope",
369343
audience="audience",
370344
)
371-
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(
372-
profile_pk2
373-
)
345+
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_pk2)
374346
assert provider1 == provider2
375347

376348

@@ -387,9 +359,7 @@ def test_oauth_private_key_auth_provider_with_different_profiles():
387359
scope="scope",
388360
audience="audience",
389361
)
390-
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(
391-
profile_pk1
392-
)
362+
provider1 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_pk1)
393363
assert isinstance(provider1, OAuthClientCredentialsAuthProvider)
394364

395365
profile_pk2 = DeltaSharingProfile(
@@ -404,7 +374,5 @@ def test_oauth_private_key_auth_provider_with_different_profiles():
404374
scope="scope",
405375
audience="audience",
406376
)
407-
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(
408-
profile_pk2
409-
)
377+
provider2 = AuthCredentialProviderFactory.create_auth_credential_provider(profile_pk2)
410378
assert provider1 != provider2

0 commit comments

Comments
 (0)