From 8037039567c1b02d5b4118176be269d58bfb5d9d Mon Sep 17 00:00:00 2001 From: iequidoo Date: Mon, 6 Jan 2025 19:39:18 -0300 Subject: [PATCH] fix: Don't emit MsgsNoticed when a message was seen on IMAP `receive_imf` doesn't emit `MsgsNoticed` on receipt of an IMAP-seen message, so the code was inconsistent. The easiest fix is to not emit `MsgsNoticed` when a message was seen on another device, we don't want to emit `MsgsNoticed` if not all messages are seen, otherwise that removes useful notifications from UIs and may lead to missing messages. Checking that all previous chat messages are at least `InNoticed` looks complicated, let's not do this for now. --- src/imap.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/imap.rs b/src/imap.rs index 9248db7d4f..c072c0c8bb 100644 --- a/src/imap.rs +++ b/src/imap.rs @@ -1284,7 +1284,6 @@ impl Session { context.on_archived_chats_maybe_noticed(); } for updated_chat_id in updated_chat_ids { - context.emit_event(EventType::MsgsNoticed(updated_chat_id)); chatlist_events::emit_chatlist_item_changed(context, updated_chat_id); }