-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deltachat-rpc-server-win64.exe is marked as malware by VirusTotal since 1.150.0 #6338
Comments
At this point it is only Microsoft detecting Trojan:Win64/CobaltStrike.IM!MTB Also here: tree-sitter/tree-sitter-css#35 |
https://docs.virustotal.com/docs/false-positive-contacts lists https://www.microsoft.com/en-us/wdsi/filesubmission as a place to report false positives. There is a way to upload your binary as a "software developer", probably we should do it from Delta Chat related account. |
What's interesting is that the 32-bit build of 1.150 is not flagged: https://www.virustotal.com/gui/file/98c85c5cd0fab1be0f12dc4768b889aaaaa53a8124ced8c5039e24c08ea260d6 |
1.152.0 release, the latest one at the moment and the one submitted as false positive: We can click to rescan it later and see if the problem is resolved. |
I have also tested that checking out v1.149.0 tag and running Here is the diff compared to 1.149.0:
|
Unlikely, it's been marking other releases as potentially malicious |
I mean if Microsoft does something about false positive, VirusTotal should stop detecting old binaries as malware as well. |
VirusTotal still flags 1.152.0 so the issue remains open until we can build with new Rust and get 0 detections on VirusTotal and can merge #6348 |
Current situation with #6348 https://www.virustotal.com/old-browsers/file/5ba9d321c00a387fcab67ec8ab59325f118307c7914e45f04eb2efdaa81ef655 (2/76, Ikarus + Google) https://www.virustotal.com/gui/file/5ba9d321c00a387fcab67ec8ab59325f118307c7914e45f04eb2efdaa81ef655 (2/72, Google + Ikarus) |
According to https://docs.virustotal.com/docs/false-positive-contacts we should write to [email protected] or what? Not going to do it. |
@link2xt The situation has become worse, now 5 of 76 scanners report a trojan. (Just click one of the links you posted above.) |
What about Microsoft? Because I'm not sure if we should care about Google. Does it not let you download the installer through Chrome? |
Here is 1.153.0 compiled with new Rust from PR #6348: 1.153.0 with current Rust is clean: |
This "Ikarus" is probably just using outdated Microsoft antivirus and will update eventually, but Google I'd like to have fixed before we upgrade. It probably affects Google Drive at least. |
Another update of PR #6348, now two (Google + Ikarus) again. https://www.virustotal.com/old-browsers/file/d51e6f5323b20fe9cc6543e967b6521612187c186459b8287a938a788aa10d5d Similar issue, looks like these two vendors like to generate false positives: java-native-access/jna#1627 |
Edit: as pointed out below: this version is not marked as malware, because it uses old Rust. |
All releases are still compiled with old Rust. Rust version is pinned by I already posted above that "1.153.0 with current Rust is clean" and a link to https://www.virustotal.com/gui/file/e4260a237473b147e8ea6fd4a4260179c9dacd045734540fc86c5077e079589c, this was always clean and this does not change, but it is built with old Rust, some nightly below 1.81. As soon as we merge #6348 we will get this in releases: |
I will wait until the fix deltachat/deltachat-desktop#4469 for desktop is merged, then merge #6348. We will still have false positives for Google and Ikarus but it will be easier to report such false positives if we can point to releases. |
This version is marked as malware:
https://github.com/deltachat/deltachat-core-rust/releases/download/v1.150.0/deltachat-rpc-server-win64.exe
sha256sum of 1.149.0 is 347bdcf0905cb19335ae915ea7a256db1396e48eecf848ede6fe116f4f82ebb9, it is clean:
https://www.virustotal.com/gui/file/347bdcf0905cb19335ae915ea7a256db1396e48eecf848ede6fe116f4f82ebb9
I built it with
nix build .#deltachat-rpc-server-win64
and it produced the same binary with the same sha256, the version uploaded to GitHub releases, PyPI and npm is reproducible.sha256sum of 1.150.0 is 12cdbb651b793c2b81b3a08a8ea10942dcfdf30777381c947b3002dad3c9d4e4, I also reproduced it with Nix, but this one is flagged:
https://www.virustotal.com/gui/file/12cdbb651b793c2b81b3a08a8ea10942dcfdf30777381c947b3002dad3c9d4e4
Going to bisect to the commit now.
git bisect log
Commit 60163cb (bad, 1/72 flagged): https://www.virustotal.com/gui/file/a76476948e06af68a513e542c02f0a5c66c970b71aa0590096bdcdf80d212dd0
Commit 1e886a3 (good): https://www.virustotal.com/gui/file/5137e6c543ab985872c06a019b08a21ffc1c5d0cfa7d2d968e007b08d8ad0a06
Commit 010b655 (bad, 1/72 flagged):
https://www.virustotal.com/gui/file/6bcbc36ab460d15c847c402d3b3d44e2adde277f6cdce5e16bf284b59b874d71
Commit 19dc16d (good):
https://www.virustotal.com/gui/file/e95316049c1e8123823eb475406425d33b9922b04c1f249d7596f6722a425740
Commit fe53eb2 (bad, 1/72 flagged):
https://www.virustotal.com/gui/file/6bcbc36ab460d15c847c402d3b3d44e2adde277f6cdce5e16bf284b59b874d71
Commit 9c0e932 (bad, 1/72 flagged):
https://www.virustotal.com/gui/file/0512e8b2e25c64c11d470e54ca931f464986cd7d41031c02e6dee53425d86ad2
I suspect it will end up at
nix flake update
commit which implicitly updated Rust, but doing proper git bisect currently anyway.EDIT: so it is 9c0e932 which updated Rust.
This problem results in antivirus deleting deltachat-rpc-server.exe when installing Delta Chat Desktop on Windows and breaking the setup: deltachat/deltachat-desktop#4209
The text was updated successfully, but these errors were encountered: