Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not possible to send webxdc app staged in draft with JSON-RPC API #4643

Open
adbenitez opened this issue Aug 30, 2023 · 7 comments · Fixed by #4839 · May be fixed by #6426
Open

not possible to send webxdc app staged in draft with JSON-RPC API #4643

adbenitez opened this issue Aug 30, 2023 · 7 comments · Fixed by #4839 · May be fixed by #6426
Assignees
Labels

Comments

@adbenitez
Copy link
Member

adbenitez commented Aug 30, 2023

it is common need to stag a webxdc app to setup its state before sending it, that is set the app as draft (like on DC android), but with current JSON-RPC API it is not possible to send the staged draft, or send a new message with status updates set

@Septias
Copy link
Collaborator

Septias commented Oct 8, 2023

Why did you add the jsonrpc label if you want to have a more powerful webxdc api? I guess you are talking about sending staged webxdcs from within other webxdcs?

@hpk42
Copy link
Contributor

hpk42 commented Oct 9, 2023

could you close this issue and, if needed, open a new one, at best after a discussion with Bjoern or so, and try to phrase it as an actionable item for core? I am btw not sure i understand precisely -- staging in android including creating some app-updates works but that's probably not what you mean?

@r10s
Copy link
Member

r10s commented Oct 9, 2023

imu, the issue is, that jsonrpc does not allow to stage+prepare webxdc apps in draft mode (so, desktop cannot implement stage+prepare)

otoh, stage+prepare webxdc apps is possible in cffi (android/ios use cffi and allow stage+prepare therefore)

so, the actionable item is to modify the jsonrpc so that stage+prepare webxdc apps is possible.

i also had to re-read several times - the issue makes sense only if you read the tag as well - in general, i think, issue texts should be understandable by not reading tags or headlines (which should only summarise and organise) - but i am sure, i am am also sometimes failing on that :)

@adbenitez
Copy link
Member Author

adbenitez commented Oct 10, 2023

thanks @r10s, yes that was the intention, I edited the post, the issue is I made a typo and said "webxdc api" instead of "jsonrpc api" that is why everyone else was confused 😅

this issue is an important stepping stone so DC Desktop can add staging/drafting of webxdc apps before sending them

@adbenitez adbenitez changed the title not possible to send webxdc app staged in draft not possible to send webxdc app staged in draft with JSON-RPC API Oct 10, 2023
@hpk42
Copy link
Contributor

hpk42 commented Oct 10, 2023

thanks @r10s, yes that was the intention, I edited the post, the issue is I made a typo and said "webxdc api" instead of "jsonrpc api" that is why everyone else was confused 😅

this issue is an important stepping stone so DC Desktop can add staging/drafting of webxdc apps before sending them

you still didn't address my comment, though -- which would mean maybe something like "implement json-rpc support for staging draft webxdc apps" -- linking the existing CFFI functions in the description.

There is another related practise i discussed with link2xt and r10s yesterday: core API issues and PRs should have a corresponding UI PR and not be done and discussed independently from usage. So if there is no ongoing work/PR to use a new jsonrpc-api i suggest to close this issue here.

@Septias
Copy link
Collaborator

Septias commented Oct 15, 2023

closing because there does not seem to be a need for this. Feel free to reopen if I'm wrong @adbenitez

@Septias Septias closed this as completed Oct 15, 2023
@link2xt link2xt reopened this Oct 15, 2023
@link2xt link2xt added the bot label Oct 15, 2023
@link2xt
Copy link
Collaborator

link2xt commented Oct 15, 2023

There is a corresponding desktop issue: deltachat/deltachat-desktop#2722

New deltachat-rpc-client bindings are now uploaded to PyPI #4523. New JSON-RPC bindings are no longer experimental, e.g. [email protected] and matterbridge are using it, so bots will also need this if they want to prepare .xdc before sending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants