Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check where Dialog closed by double escape should be handled #4397

Closed
nicodh opened this issue Dec 8, 2024 · 2 comments · Fixed by #4890
Closed

Check where Dialog closed by double escape should be handled #4397

nicodh opened this issue Dec 8, 2024 · 2 comments · Fixed by #4890
Assignees
Labels
bug Something isn't working technical debt

Comments

@nicodh
Copy link
Member

nicodh commented Dec 8, 2024

Followup to #4365

It turns out that you can close any Dialog in Chrome by firing excape key twice. We should make sure that this causes no unexpected behaviour. Probably only Dialogs with canEscapeKeyClose={false} are affected

@maxphilippov
Copy link
Collaborator

Sorry, that's something that should be probably fixed by my #4205. I'll try to get back with an update in a couple of days, cause I did change some code mentioned in #4365 discussion.

@Simon-Laux
Copy link
Member

I just confirmed that double escape closes dialog where we have escape disabled. (welcome screen and login screen)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants