Bump pyo3-file and avoid extra gil acquire (developmentseed#406)

kylebarron · web-flow · commit 1b2fcc0ba962 · 2025-04-04T15:46:34.000Z
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -29,7 +29,7 @@ indexmap = "2"
 object_store = "0.12"
 pyo3 = { version = "0.24", features = ["macros", "indexmap"] }
 pyo3-async-runtimes = { version = "0.24", features = ["tokio-runtime"] }
-pyo3-file = "0.11"
+pyo3-file = "0.12"
 thiserror = "1"
 tokio = "1.40"
 url = "2"
diff --git a/obstore/src/put.rs b/obstore/src/put.rs
@@ -249,7 +249,7 @@ impl<'py> FromPyObject<'py> for PutInput {
         // Check for file-like object
         else if ob.hasattr(intern!(py, "read"))? && ob.hasattr(intern!(py, "seek"))? {
             Ok(Self::Pull(PullSource::FileLike(
-                PyFileLikeObject::with_requirements(ob.clone().unbind(), true, false, true, false)?,
+                PyFileLikeObject::py_with_requirements(ob.clone(), true, false, true, false)?,
             )))
         }
         // Ensure we check _first_ for an async generator before a sync one

Original file line number	Diff line number	Diff line change
`@@ -249,7 +249,7 @@ impl<'py> FromPyObject<'py> for PutInput {`
`249`	`249`	`// Check for file-like object`
`250`	`250`	`else if ob.hasattr(intern!(py, "read"))? && ob.hasattr(intern!(py, "seek"))? {`
`251`	`251`	`Ok(Self::Pull(PullSource::FileLike(`
`252`		`- PyFileLikeObject::with_requirements(ob.clone().unbind(), true, false, true, false)?,`
	`252`	`+ PyFileLikeObject::py_with_requirements(ob.clone(), true, false, true, false)?,`
`253`	`253`	`)))`
`254`	`254`	`}`
`255`	`255`	`// Ensure we check _first_ for an async generator before a sync one`