refactor(ext/node): use Promise.withResolvers (#28917)

Author: bartlomieju

ext/node/polyfills/child_process.ts

@@ -6,7 +6,7 @@
 // TODO(petamoriken): enable prefer-primordials for node polyfills
 // deno-lint-ignore-file prefer-primordials
 
-import { internals } from "ext:core/mod.js";
+import { internals, primordials } from "ext:core/mod.js";
 import {
   op_bootstrap_unstable_args,
   op_node_child_ipc_pipe,
@@ -37,16 +37,7 @@ import {
   ERR_OUT_OF_RANGE,
   genericNodeError,
 } from "ext:deno_node/internal/errors.ts";
-import {
-  ArrayIsArray,
-  ArrayPrototypeJoin,
-  ArrayPrototypePush,
-  ArrayPrototypeSlice,
-  ObjectAssign,
-  StringPrototypeSlice,
-} from "ext:deno_node/internal/primordials.mjs";
 import { getSystemErrorName, promisify } from "node:util";
-import { createDeferredPromise } from "ext:deno_node/internal/util.mjs";
 import process from "node:process";
 import { Buffer } from "node:buffer";
 import {
@@ -55,6 +46,16 @@ import {
 } from "ext:deno_node/internal/util.mjs";
 import { kNeedsNpmProcessState } from "ext:deno_process/40_process.js";
 
+const {
+  ArrayIsArray,
+  ArrayPrototypeJoin,
+  ArrayPrototypePush,
+  ArrayPrototypeSlice,
+  ObjectAssign,
+  PromiseWithResolvers,
+  StringPrototypeSlice,
+} = primordials;
+
 const MAX_BUFFER = 1024 * 1024;
 
 type ForkOptions = ChildProcessOptions;
@@ -345,11 +346,7 @@ type ExecExceptionForPromisify = ExecException & ExecOutputForPromisify;
 
 const customPromiseExecFunction = (orig: typeof exec) => {
   return (...args: [command: string, options: ExecOptions]) => {
-    const { promise, resolve, reject } = createDeferredPromise() as unknown as {
-      promise: PromiseWithChild<ExecOutputForPromisify>;
-      resolve?: (value: ExecOutputForPromisify) => void;
-      reject?: (reason?: ExecExceptionForPromisify) => void;
-    };
+    const { promise, resolve, reject } = PromiseWithResolvers();
 
     promise.child = orig(...args, (err, stdout, stderr) => {
       if (err !== null) {
@@ -681,11 +678,7 @@ const customPromiseExecFileFunction = (
       options?: ExecFileOptions,
     ]
   ) => {
-    const { promise, resolve, reject } = createDeferredPromise() as unknown as {
-      promise: PromiseWithChild<ExecOutputForPromisify>;
-      resolve?: (value: ExecOutputForPromisify) => void;
-      reject?: (reason?: ExecFileExceptionForPromisify) => void;
-    };
+    const { promise, resolve, reject } = PromiseWithResolvers();
 
     promise.child = orig(...args, (err, stdout, stderr) => {
       if (err !== null) {

ext/node/polyfills/internal/util.mjs

@@ -35,17 +35,6 @@ export function once(callback) {
   };
 }
 
-export function createDeferredPromise() {
-  let resolve;
-  let reject;
-  const promise = new Promise((res, rej) => {
-    resolve = res;
-    reject = rej;
-  });
-
-  return { promise, resolve, reject };
-}
-
 // In addition to being accessible through util.promisify.custom,
 // this symbol is registered globally and can be accessed in any environment as
 // Symbol.for('nodejs.util.promisify.custom').
@@ -175,7 +164,6 @@ promisify.custom = kCustomPromisifiedSymbol;
 
 export default {
   convertToValidSignal,
-  createDeferredPromise,
   customInspectSymbol,
   customPromisifyArgs,
   kEmptyObject,

ext/node/polyfills/util.ts

@@ -28,12 +28,10 @@ const {
   StringPrototypePadStart,
   StringPrototypeToWellFormed,
   PromiseResolve,
+  PromiseWithResolvers,
 } = primordials;
 
-import {
-  createDeferredPromise,
-  promisify,
-} from "ext:deno_node/internal/util.mjs";
+import { promisify } from "ext:deno_node/internal/util.mjs";
 import { callbackify } from "ext:deno_node/_util/_util_callbackify.js";
 import { debuglog } from "ext:deno_node/internal/util/debuglog.ts";
 import {
@@ -317,7 +315,7 @@ export async function aborted(
   if (signal.aborted) {
     return PromiseResolve();
   }
-  const abortPromise = createDeferredPromise();
+  const abortPromise = PromiseWithResolvers();
   signal[abortSignal.add](abortPromise.resolve);
   return abortPromise.promise;
 }