Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type declarations for new Set methods #22851

Closed
bartlomieju opened this issue Mar 11, 2024 · 4 comments · Fixed by #23090
Closed

Update type declarations for new Set methods #22851

bartlomieju opened this issue Mar 11, 2024 · 4 comments · Fixed by #23090
Assignees
@dsherret

Comments

@bartlomieju
Copy link
Member

No description provided.

@bartlomieju bartlomieju added this to the 1.42 milestone Mar 11, 2024
@bartlomieju bartlomieju self-assigned this Mar 11, 2024
@bartlomieju bartlomieju removed this from the 1.42 milestone Mar 26, 2024
@bartlomieju
Copy link
Member Author

PR to TypeScript that adds these methods: microsoft/TypeScript#57230

I'm thinking we should fork these (adding appropriate attribution) and then remove them in TypeScript 5.5 (when this PR is expected to land).

@bartlomieju bartlomieju assigned dsherret and unassigned bartlomieju Mar 26, 2024
@dsherret
Copy link
Member

Not sure we should do this yet when it seems like they haven't agreed upon the names in the TS PR.

@bartlomieju
Copy link
Member Author

@dsherret I think the names of APIs are fixed and we already natively support these new APIs in both TS and JS - they've been added in V8 12.3 that we now use. IMO it's better to add any type declarations and improve them over time than not expose these APIs for TS users.

@dsherret
Copy link
Member

Discussed in chat: going to use that PR, but use the Set type instead of ReadonlySetLike. Then we can restrict it further to readonly once it lands in typescript.

@dsherret dsherret mentioned this issue Mar 27, 2024
Merged
dsherret added a commit that referenced this issue Mar 27, 2024
@dsherret
feat: type declarations for new Set methods (#23090)
34a651e 
Closes #22851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsherret dsherret

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: type declarations for new Set methods dsherret/deno
2 participants
@dsherret @bartlomieju