Problems running puppeteer via deno starting from 2.5.2 (node js compat)

[nsf]

Version: Deno 2.5.2 and 2.5.3

Unfortunately I can't provide a reproducable test case. But when running our own test suite (deno script which runs puppeteer-based tests) we observe that version 2.5.2 shows strange behaviour, while version 2.5.1 works as expected. Could be something with host <-> puppeteer connection. Not sure but iirc it uses websockets. Puppeteer is a node js library, so the node js compat layer is a possible source of this bug.

On version 2.5.1 I can run my test suite successfully 3 times in a row.
On version 2.5.2 all 3 attempts are terminated with various puppeteer connection errors, which look like this:

Protocol error (Input.dispatchMouseEvent): Session closed. Most likely the page has been closed.
error: Uncaught (in promise) ConnectionClosedError: Connection closed.
    at Connection._rawSend (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Connection.js:93:35)
    at Connection.send (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Connection.js:86:21)
    at CdpPage.close (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Page.js:852:34)

Protocol error (Input.dispatchMouseEvent): Target closed
error: Uncaught (in promise) ConnectionClosedError: Connection closed.
    at Connection._rawSend (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Connection.js:93:35)
    at Connection.send (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Connection.js:86:21)
    at CdpPage.close (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Page.js:852:34)

Protocol error (Emulation.setTouchEmulationEnabled): Session closed. Most likely the page has been closed.
error: Uncaught (in promise) ConnectionClosedError: Connection closed.
    at Connection._rawSend (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Connection.js:93:35)
    at Connection.send (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Connection.js:86:21)
    at CdpPage.close (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Page.js:852:34)

[nsf]

Okay, here goes reproducable code. I'm not sure if I'm hitting the same bug here, but it is some bug.

imports (note that you need to have chromium installed under /usr/bin/chromium):

"puppeteer-core": "npm:puppeteer-core@^24.23.0"

code:

import puppeteer from "puppeteer-core";

const browser = await puppeteer.launch({
  executablePath: "/usr/bin/chromium",
  headless: true,
  defaultViewport: { width: 1280, height: 1024 },
  args: ["--window-size=1332,1226", "--hide-scrollbars"],
});

const page = await browser.newPage();
await page.goto("https://google.com");
for (let i = 0; i < 500; i++) {
  await page.evaluate("console.log(1+1);");
}
await page.close();
await browser.close();

and here are run results on different deno versions:

[nsf @ puppeteer]$ deno --version
deno 2.5.1 (stable, release, x86_64-unknown-linux-gnu)
v8 14.0.365.4-rusty
typescript 5.9.2
[nsf @ puppeteer]$ deno run -A repro.ts
[nsf @ puppeteer]$ deno run -A repro.ts
[nsf @ puppeteer]$ deno run -A repro.ts
[nsf @ puppeteer]$ deno run -A repro.ts
[nsf @ puppeteer]$ deno run -A repro.ts

[nsf @ puppeteer]$ deno --version
deno 2.5.2 (stable, release, x86_64-unknown-linux-gnu)
v8 14.0.365.5-rusty
typescript 5.9.2
[nsf @ puppeteer]$ deno run -A repro.ts
error: Uncaught (in promise) Error: Navigating frame was detached
    at LifecycleWatcher.<instance_members_initializer> (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:33:14)
    at new LifecycleWatcher (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:37:16)
    at CdpFrame.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Frame.js:145:29)
    at CdpFrame.<anonymous> (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/util/decorators.js:101:27)
    at CdpPage.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/api/Page.js:568:43)
    at file:///home/nsf/tmp/trunkery2/frontend/puppeteer/repro.ts:11:12
    at eventLoopTick (ext:core/01_core.js:218:9)
Caused by: Error: LifecycleWatcher disposed
    at LifecycleWatcher.dispose (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:170:29)
    at CdpFrame.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Frame.js:165:25)
    at async CdpPage.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/api/Page.js:568:20)
    at async file:///home/nsf/tmp/trunkery2/frontend/puppeteer/repro.ts:11:1
[nsf @ puppeteer]$ deno run -A repro.ts
[nsf @ puppeteer]$ deno run -A repro.ts
[nsf @ puppeteer]$ deno run -A repro.ts
error: Uncaught (in promise) Error: Navigating frame was detached
    at LifecycleWatcher.<instance_members_initializer> (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:33:14)
    at new LifecycleWatcher (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:37:16)
    at CdpFrame.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Frame.js:145:29)
    at CdpFrame.<anonymous> (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/util/decorators.js:101:27)
    at CdpPage.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/api/Page.js:568:43)
    at file:///home/nsf/tmp/trunkery2/frontend/puppeteer/repro.ts:11:12
    at eventLoopTick (ext:core/01_core.js:218:9)
Caused by: Error: LifecycleWatcher disposed
    at LifecycleWatcher.dispose (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:170:29)
    at CdpFrame.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Frame.js:165:25)
    at async CdpPage.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/api/Page.js:568:20)
    at async file:///home/nsf/tmp/trunkery2/frontend/puppeteer/repro.ts:11:1
[nsf @ puppeteer]$ deno run -A repro.ts
error: Uncaught (in promise) Error: Navigating frame was detached
    at LifecycleWatcher.<instance_members_initializer> (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:33:14)
    at new LifecycleWatcher (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:37:16)
    at CdpFrame.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Frame.js:145:29)
    at CdpFrame.<anonymous> (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/util/decorators.js:101:27)
    at CdpPage.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/api/Page.js:568:43)
    at file:///home/nsf/tmp/trunkery2/frontend/puppeteer/repro.ts:11:12
    at eventLoopTick (ext:core/01_core.js:218:9)
Caused by: Error: LifecycleWatcher disposed
    at LifecycleWatcher.dispose (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/LifecycleWatcher.js:170:29)
    at CdpFrame.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/cdp/Frame.js:165:25)
    at async CdpPage.goto (file:///home/nsf/.cache/deno/npm/registry.npmjs.org/puppeteer-core/24.23.0/lib/esm/puppeteer/api/Page.js:568:20)
    at async file:///home/nsf/tmp/trunkery2/frontend/puppeteer/repro.ts:11:1

[sigmaSd]

You can use deno upgrade<commit> with commits between those 2 versions to bisect the issue to the exact commit

[nsf]

This commit breaks it: 4772778
And it makes sense, as it's websocket related.

[devsnek]

so far what i've found...

example of actual underlying error (the actual message varies by the corruption, e.g. the message could also be "RSV2 and RSV3 must be clear")

RangeError: Invalid WebSocket frame: RSV1 must be clear
    at Receiver.getInfo (file://node_modules/ws/lib/receiver.js:210:26)
    at Receiver.startLoop (file://node_modules/ws/lib/receiver.js:155:16)
    at Receiver._write (file://node_modules/ws/lib/receiver.js:94:10)
    at doWrite (node:_stream_writable:649:12)
    at clearBuffer (node:_stream_writable:847:7)
    at onwrite (node:_stream_writable:705:7)
    at Receiver.startLoop (file://node_modules/ws/lib/receiver.js:176:25)
    at file://node_modules/ws/lib/receiver.js:604:16
    at ext:deno_web/02_timers.js:35:14
    at eventLoopTick (ext:core/01_core.js:214:13) 

actual data on the wire (as seen with wireshark) is clean.

reverting 4772778 does fix the issue.

setting allowSynchronousEvents: true in node_modules/puppeteer-core/lib/esm/puppeteer/node/NodeWebSocketTransport.js so that we avoid setImmediate also fixes the issue.

so my guess is that between the incorrect implementation of setImmediate in deno (#28016) and the removal of the tokio::io::duplex in 4772778, something in the timing changed enough to confuse ws.

i haven't been able to make a repro that doesn't rely on puppeteer though.

i will dig in more tomorrow and if i can't find the cause i'll open a revert.