Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VETS-API] [DISCOVERY] Iterate on Current Backend CI Checks #93566

Closed
13 tasks done
ryan-mcneil opened this issue Sep 24, 2024 · 2 comments
Closed
13 tasks done

[VETS-API] [DISCOVERY] Iterate on Current Backend CI Checks #93566

ryan-mcneil opened this issue Sep 24, 2024 · 2 comments

Comments

@ryan-mcneil
Copy link
Contributor

ryan-mcneil commented Sep 24, 2024

Issue Description

There are currently several issues with the GHAs that are attempting to simplify the lives of the BE CoP when it comes to approving PRs, but instead have had some unintended effects that are blocking/slowing development, raising a ton of noise, and adding to our workload. I believe we need to to step back and establish what we're trying to accomplish, what we have that's working, what doesn't work, and what needs to be put in place to achieve our ideal workflow.


Tasks

  • Establish explicit criteria for PR approval
  • Whiteboard ideal process with edge cases
    • failing specs
    • updating to master
    • re-approvals
    • approvals required by multiple teams
    • teams exempt from backend approval (Mobile, Identity, Lighthouse?)
  • Consider options for workflows to meet these requirements, regardless of what is already in place
    • Determine if any existing checks can be used or easily modified to meet these
  • Discuss options with CoP
  • Create tickets for follow up work

Acceptance Criteria

  • Confluence page is created with whiteboard and decisions documented
  • Tickets created
@ryan-mcneil
Copy link
Contributor Author

ryan-mcneil commented Oct 22, 2024

@ryan-mcneil ryan-mcneil changed the title [VETS-API] Iterate on Current Backend CI Checks [VETS-API] [DISCOVERY] Iterate on Current Backend CI Checks Oct 22, 2024
@ryan-mcneil
Copy link
Contributor Author

Next ticket: #95609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants