Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midpoint Review - Content Feedback - Veteran Facing Forms - Service history patterns #94442

Open
11 of 15 tasks
KKitagawa-Bosch opened this issue Oct 7, 2024 · 1 comment
Open
11 of 15 tasks
Assignees
Labels
1-forms-audit-digitize Veteran Facing Forms Team collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements content midpoint-review Collaboration Cycle Midpoint Review pattern-new

Comments

@KKitagawa-Bosch
Copy link
Contributor

KKitagawa-Bosch commented Oct 7, 2024

Next Steps for the VFS team

  • Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
  • Comment on this ticket:
    • If the Platform reviewer has any Thoughts/Questions that require responses.
    • When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
    • When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
  • Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
  • Close the ticket when all feedback has been addressed.

Thoughts/questions

Feedback

Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).

  • Must: make sure all apostrophes are curly, never straight apostrophes
  • Must: in the DD214 section, in the sentence "Learn more about how to request a DD214" the word "request" is missing the letter "t".
  • Must: make sure all complete sentences have terminal punctuation, including in bulleted lists and checkbox lists
  • Should: under the "is this information correct" question, the phrasing "if not, select no" feels redundant and a bit clunky, consider rephrasing.

Governance team actions

  • Format feedback as individual tasks (check boxes)
  • Assign this ticket to the VFS team member that opened the Slack request
  • Add the VFS team product label
  • Add the VFS team the feature label (if applicable)
  • Add the touchpoint labels
  • Add the practice area labels
  • Add the Collaboration Cycle initiative milestone
@KKitagawa-Bosch KKitagawa-Bosch added 1-forms-audit-digitize Veteran Facing Forms Team collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements content midpoint-review Collaboration Cycle Midpoint Review pattern-new labels Oct 7, 2024
@JaciWilkinson
Copy link

Asked @KKitagawa-Bosch for clarification about "make sure all apostrophes are curly, never straight apostrophes" - don't understand where those straight apostrophes exist in the design or how to change them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-forms-audit-digitize Veteran Facing Forms Team collab-cycle-feedback For VSP Collaboration cycle feedback assigned to VFS collaboration-cycle For VSP Collaboration Cycle requests and improvements content midpoint-review Collaboration Cycle Midpoint Review pattern-new
Projects
None yet
Development

No branches or pull requests

3 participants