upload(): rsync exclude options not recognised due to escaping

[micschk]

• Deployer version: 7.0.2
• Deployment OS: macOS Monterey 12.4

(Duplicate/re-opening of #2972, which references introduction of this bug in f4e2d6b)

When calling upload() with --exclude options for rsync, these are escaped via escapeshellarg.
In the case of --exclude, this somehow results in the option not being recognized by rsync:
upload('test-dir', '{{release_path}}', ['options' => [ "--exclude={'composer.lock','vendor'}" ]]);
upload('test-dir', '{{release_path}}', ['options' => [ "--exclude='vendor'", "--exclude='composer.lock'" ]]);
upload('test-dir', '{{release_path}}', ['options' => [ '--exclude="vendor"', '--exclude="composer.lock"' ]]);

Results in run'ing:
rsync '-azP' '--exclude={'\''composer.lock'\'','\''vendor'\''}' ...etc
rsync '-azP' '--exclude='\''vendor'\''' '--exclude='\''composer.lock'\''' ...etc
rsync '-azP' '--exclude="vendor"' '--exclude="composer.lock"' ...etc
...which all three include both composer.lock and vendor dir in the sync instead of being excluded.

Running the same rsync command without 's around the --exclude options, does work correctly...
Also the 's do not seem to cause issues around other arguments, shorthand (eg '-azP') nor longhand (eg '--delete').

[micschk]

Not sure why this issue was converted to a discussion as it seems to be an actual bug in the way rsync arguments are escaped.
I'll create a PR to add a note of my workaround to the documentation.

Workaround:

• add a separate --exclude=... for each exclude (instead of one argument {'with','a','list'}, which I could not get to work properly)
• do not wrap the excludes in quotes ('single' nor "double")

Some clarification of this behaviour by rsync: https://superuser.com/questions/1418666/fish-generated-rsync-command-has-unexpected-effects#1418675