Deployer not honoring sub_directory on dep push

[skyracer2012]

Deployer Version

v7.5.8

Target OS

Ubuntu 22.04

Which PHP version are you using?

PHP 8.3

Content of deploy.php or deploy.yaml

<?php
namespace Deployer;

require 'recipe/laravel.php';

// Config

set('repository', '[email protected]:skyracer2012/repo.git');
set('sub_directory', 'control-panel');
set('nvm', 'source $HOME/.nvm/nvm.sh &&');

add('shared_files', []);
add('shared_dirs', []);
add('writable_dirs', []);

// Hosts

host('nginx-mail-1')
    ->set('remote_user', 'root')
    ->set('deploy_path', '~/repo-deployer')
    ->set('become', 'www-data');
host('nginx-mail-2')
    ->set('remote_user', 'root')
    ->set('deploy_path', '~/repo-deployer')
    ->set('become', 'www-data');

// Hooks

after('deploy:failed', 'deploy:unlock');

task('build_vite', function () {
    cd('{{release_path}}');
    run('{{nvm}} npm install');
    run('{{nvm}} npm run build');
});
after('deploy:vendors', 'build_vite');
after('deploy:publish', 'artisan:queue:restart');

Steps to reproduce

1. Create a project and deploy it using the sub_directory option.
2. Change a file in your source code (inside of the sub directory which is deployed as the root)
3. run deploy push

It seems like deployer does not rewrite the source path (containing the folder within sub_directory) to the real path of the deployment (only the contents of sub_directory without the sub_directory being in the path)

One other option could be that the become parameter is not honored.

This the following error occurs:

dep push
Select hosts: (comma separated)
  [0] host-1
  [1] host-2
 > 0
task push
[host-1] info uploading:
[host-1]  - control-panel/app/File1.php
[host-1]  - control-panel/app/File2.php
[host-1]  - control-panel/app/File3.php
[host-1]  - deploy.php
[host-1]  error  in push.php on line 17:
[host-1] run rsync '-azP' '--relative' '-e' 'ssh '\''-A'\'' '\''-o'\'' '\''ControlMaster=auto'\'' '\''-o'\'' '\''ControlPersist=60'\'' '\''-o'\'' '\''ControlPath=~/.ssh/root@host-1'\''' '--rsync-path' 'sudo -H -u www-data rsync' 'control-panel/app/File1.php' 'control-panel/app/File2.php' 'control-panel/app/File3.php' 'deploy.php' 'root@host-1:~/repo-deployer/current'
[host-1] err rsync: [sender] link_stat "/home/jeff/repo/control-panel/control-panel/app/File1.php" failed: No such file or directory (2)
[host-1] err rsync: [sender] link_stat "/home/jeff/repo/control-panel/control-panel/app/File2.php" failed: No such file or directory (2)
[host-1] err rsync: [sender] link_stat "/home/jeff/repo/control-panel/control-panel/app/File3.php" failed: No such file or directory (2)
[host-1] err rsync: [sender] link_stat "/home/jeff/repo/control-panel/deploy.php" failed: No such file or directory (2)
[host-1] err rsync: [Receiver] ERROR: cannot stat destination "/root/repo-deployer/current": Permission denied (13)
[host-1] err rsync error: errors selecting input/output files, dirs (code 3) at main.c(772) [Receiver=3.2.7]
[host-1] sending incremental file list
[host-1] exit code 3 (Unknown error)
ERROR: Task push failed!

#3709 seems not to be related due to him saying he never deployed the repo before pushing

[antonmedv]

Looks like a bug. Could you please update the command?

[antonmedv]

Some tests will be prefect.