TYPO3 recipies out of date

[garvinhicking]

Deployer Version

8.x

Target OS

macOS

Which PHP version are you using?

PHP 8.4

Content of deploy.php or deploy.yaml

No response

Steps to reproduce

The recipe listed on https://deployer.org/docs/8.x/recipe/typo3 is much out of date and doesn't reflect modern best practices (no composer dependency on the target, for example).

Are there plans to rework this or accept contributions? Because #3754 has been closed without a comment, and goes into the right direction.

The maintainer of the GitLab TYPO3 template, which also has a deployer config https://typo3.org/article/gitlabs-built-in-typo3-project-template - specifically see https://gitlab.com/gitlab-org/project-templates/typo3-distribution/-/blob/main/deploy.yaml. This could be a great starting point.

I would really like the deployer site to either link to that recipe, or allow a contribution to add/modify the current recipe. What do you think? :-)

Otherwise I would say removing the TYPO3 recipe or marking it as "outdated" would be beneficial?

Thanks a lot for your work on deployer and offering choices to the community!

[antonmedv]

Sure, we can rework the TYPO3 recipe. The #3754 was closed as it was very specific and low quality.

[garvinhicking]

Thanks for the quick reply! I must admit I'm not versed with deployer myself.

Would you say that either https://gitlab.com/gitlab-org/project-templates/typo3-distribution/-/blob/main/packages/site-distribution/Configuration/DeployerRsync.php or https://github.com/helhum/typo3-deployer-recipe/blob/main/recipe/helhum/typo3.php (which are the main packages the TYPO3 community seems to use nowadays) is of sufficient quality to be ported to your recipe repository?

If so, I would suggest to completely replace the current recipie that does not work with TYPO3 versions released after 2022 with one of those two. I hope to be able to then rework those recipies to the docs format, but I might need some help there to comply with the proper expectations.

[antonmedv]

Also would be nice if it uses common recipe, and do not reimplement the rsync thing.

[david-bonhagen]

On it, will keep you posted.

[david-bonhagen]

@antonmedv I did some research within the TYPO3 community, the rsync part is considered important for all CI/CD related deployment strategies or if the host server is not properly equipped with the needed requirements. So the general opinion is that it would be valuable to preserve this approach in a boilerplate recipe.

That said, maybe a hybrid solution could be implemented, that checks for the repository first. If the repo exists, the recipe continues with the common recipe to deploy, if not, it falls back to the rsync method.

Would that approach be something you could agree on? And / or would you have specific other requirements for this, that should be met? I already prepared a solution, but want to make sure, it fits your idea.

[antonmedv]

Please let me take a look)

[david-bonhagen]

Of course, PR can be found here.

[oliverklee]

Hi, Oliver Klee from the TYPO3 Best Practices Team here. Any of the two linked reciped would be an improvement IMHO.

[david-bonhagen]

Hi @antonmedv, just a quick question, when do you plan to publish the next deployer release? There is still some work to be done on the documentation for the updated recipe, just to have a sense of time on this.

[antonmedv]

I am on vacation. I will try to deploy it either tonight in the evening or next week.