Skip to content

Commit 137ba0b

Browse files
committed
chore: no log messages for ipc feature
like jacob mentioned, logs regarding this feature would be confusing to users. thanks to being able to check the state of iptables, as well as agentd logs, we can pretty easily debug thwere this failed
1 parent 407f4d2 commit 137ba0b

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

pkg/machine/ipc_client.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7-
"log"
87
"net"
98
"os"
109
"strings"
@@ -28,7 +27,6 @@ func AllowBuilderIPViaIPC(ctx context.Context, endpoint string) error {
2827
if os.IsNotExist(err) {
2928
return nil
3029
}
31-
log.Printf("failed to check IPC socket: %v\n", err)
3230
}
3331

3432
client, err := ipc.StartClient("depot-agentd", &ipc.ClientConfig{
@@ -37,7 +35,6 @@ func AllowBuilderIPViaIPC(ctx context.Context, endpoint string) error {
3735
if err != nil {
3836
// If we can't connect to the IPC server, log it but don't fail the build
3937
// The IPC server only runs if the egress filter is enabled
40-
log.Println("failed to connect to IPC server", "error", err)
4138
return nil
4239
}
4340
defer client.Close()
@@ -93,7 +90,6 @@ connected:
9390
}
9491

9592
if success, ok := response["success"].(bool); ok && success {
96-
log.Printf("Successfully added builder IP %s to allowlist", ip)
9793
return nil
9894
}
9995

pkg/machine/machine.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,8 @@ func Acquire(ctx context.Context, buildID, token, platform string) (*Machine, er
8585

8686
// If running in Depot GHA environment, allowlist the builder IP via IPC
8787
if helpers.IsDepotGitHubActionsRunner() {
88-
if err := AllowBuilderIPViaIPC(ctx, m.Addr); err != nil {
89-
// Log the error but don't fail the build
90-
log.Printf("Warning: failed to allowlist builder IP via IPC: %v", err)
91-
}
88+
// if this is failing, we can check by ssh'ing into the machine
89+
_ = AllowBuilderIPViaIPC(ctx, m.Addr)
9290
}
9391

9492
// When testing locally, we don't have TLS certs.

0 commit comments

Comments
 (0)