Skip to content
This repository has been archived by the owner on Dec 20, 2017. It is now read-only.

fetchData is being called twice on Daily Rollup #302

Open
nickjs opened this issue Feb 10, 2017 · 4 comments
Open

fetchData is being called twice on Daily Rollup #302

nickjs opened this issue Feb 10, 2017 · 4 comments
Milestone

Comments

@nickjs
Copy link
Contributor

nickjs commented Feb 10, 2017

No description provided.

@nickjs nickjs added the bug label Feb 10, 2017
@nickjs nickjs added this to the Sprint 15 (6 Feb - 12 Feb) milestone Feb 10, 2017
@nickjs nickjs self-assigned this Feb 10, 2017
@hunterp hunterp modified the milestones: Sprint 15 (6 Feb - 12 Feb), Sprint 16 (21 Feb - 25 Feb) Feb 13, 2017
@erincd erincd modified the milestones: Sprint 16 (13 Feb - 17 Feb), Sprint 17 (21 Feb - 25 Feb), Sprint 18 (26 Feb - 4 Mar) Feb 21, 2017
@erincd erincd added the nicks label Feb 28, 2017
@NickHeiner
Copy link
Contributor

Slack conversation

@NickHeiner
Copy link
Contributor

Relevant code snippet in Page:

	componentWillReceiveProps(props, nextContext) {
		if (props !== this.props) {
			this.loadData(props)
		} else if (this.context && (this.context !== nextContext)) {
			this.loadData(props)
		}

	}

	componentDidMount() {
		setMessages(this.props, this.state)
		this.loadData(this.props)
	}

@NickHeiner
Copy link
Contributor

@erincd if we are behind schedule, you may wish to cut this one. It's annoying to us devs that it happens, and it may make the end-user experience a bit slower because it's extra network traffic. But aside from that, I'm not sure that this has a user-facing impact.

@erincd
Copy link
Contributor

erincd commented Mar 5, 2017

ahh thanks nick. I was literally just coming here to let you guys know I don't have a sense for the priority here. I'll push it two sprints out and we can revisit.

@erincd erincd modified the milestones: Sprint 20 ( 13 March - 19 March), Sprint 18 (26 Feb - 4 Mar) Mar 5, 2017
@erincd erincd removed the nicks label Mar 7, 2017
@erincd erincd modified the milestones: Sprint 20 ( 13 March - 19 March), Sprint 21 (20-26 March) Mar 13, 2017
@erincd erincd modified the milestones: Sprint 21 (20-26 March), For NATO Mar 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants