This repository has been archived by the owner on Dec 20, 2017. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
fetchData
is being called twice on Daily Rollup
#302
Milestone
Comments
hunterp
modified the milestones:
Sprint 15 (6 Feb - 12 Feb),
Sprint 16 (21 Feb - 25 Feb)
Feb 13, 2017
erincd
modified the milestones:
Sprint 16 (13 Feb - 17 Feb),
Sprint 17 (21 Feb - 25 Feb),
Sprint 18 (26 Feb - 4 Mar)
Feb 21, 2017
Relevant code snippet in componentWillReceiveProps(props, nextContext) {
if (props !== this.props) {
this.loadData(props)
} else if (this.context && (this.context !== nextContext)) {
this.loadData(props)
}
}
componentDidMount() {
setMessages(this.props, this.state)
this.loadData(this.props)
} |
@erincd if we are behind schedule, you may wish to cut this one. It's annoying to us devs that it happens, and it may make the end-user experience a bit slower because it's extra network traffic. But aside from that, I'm not sure that this has a user-facing impact. |
ahh thanks nick. I was literally just coming here to let you guys know I don't have a sense for the priority here. I'll push it two sprints out and we can revisit. |
erincd
modified the milestones:
Sprint 20 ( 13 March - 19 March),
Sprint 18 (26 Feb - 4 Mar)
Mar 5, 2017
erincd
modified the milestones:
Sprint 20 ( 13 March - 19 March),
Sprint 21 (20-26 March)
Mar 13, 2017
erincd
removed
blue sky goals
bug
design
nicks
triage
Ready
structured playtime
super user workflow
labels
Apr 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
No description provided.
The text was updated successfully, but these errors were encountered: