Skip to content

Feature/dynamic logo from skin #3180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

AoKoori
Copy link

@AoKoori AoKoori commented Mar 6, 2025

Feat(logo): load logo from skin :

Add feature to modify displayed logo in K9s console from skins

Description :

This PR introduces a new feature that allows users to modify the displayed logo in the K9s console by loading it from the skin of the context.

Changes :

Feature Implementation :

Added functionality to load and display the logo from the context skin in the K9s console.
Updated the configuration to support custom logos.

How to load a custom logo :

it's really simple in your skin put this or create your own ascii art
(k9s skin doc)

# Skin...
k9s:
  body:
    logoUrl: https://raw.githubusercontent.com/AoKoori/k9s/refs/heads/Feature/dynamic-logo-from-skin/assets/dev.txt
    fgColor: red
    bgColor: default
    logoColor: red

Testing :

  • Manual testing performed to ensure the logo is correctly loaded and displayed from the context skin.
  • Manual testing performed to ensure the default logo is displayed if none is provided in the skin.

Screenshots :

Here are some exemples
image
image

@AoKoori AoKoori mentioned this pull request Mar 9, 2025
@derailed
Copy link
Owner

derailed commented Mar 9, 2025

@AoKoori Nice! I think it would be even cooler if the ascii asset was not hardcoded in the skin but comes from an external location. That way folks can pitch in their fav cluster type markers and folks within a given org can share theirs.
Also looks like the tests are failing since this should default to the std k9s logo....

@derailed derailed added enhancement New feature or request needs-tlc Pr needs additional updates labels Mar 9, 2025
@AoKoori
Copy link
Author

AoKoori commented Mar 19, 2025

@derailed ok i've modified the logo source now it takes an url in the skin as a source to get the logo

@AoKoori AoKoori closed this Mar 19, 2025
@AoKoori AoKoori force-pushed the Feature/dynamic-logo-from-skin branch from 828bba0 to 1e9f85d Compare March 19, 2025 22:02
@AoKoori AoKoori mentioned this pull request Mar 19, 2025
2 tasks
@AoKoori
Copy link
Author

AoKoori commented Mar 19, 2025

Here is a clean PR #3225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-tlc Pr needs additional updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants